pfSense

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php

Merge pull request #2298 from NOYB/WebGUI_Left_Column_Labels_Hyper

HTML Compliance - Form Group - Label For

The for attribute of the label element must refer to a non-hidden form control.

WebGUI Left Column Labels Hyper

Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0

Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.

No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes....

HTML Compliance - Form Select

Element option without attribute label must not be empty.

Applying htmlspecialchars on form action attribute causes ampersands to multiply, and also breaks multi-parameter query strings that are delimited with ampersands.

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

HTML Compliance - Collapsible Form Section HREF

Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.

<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20....