Project

General

Profile

« Previous | Next » 

Revision 9f6d92a2

Added by Phil Davis over 9 years ago

status_dhcp6_leases incorrect comparison operator

rather than assignment.
Also $dhcpv6leaseinlocaltime was also being re-used as the value part of the foreach - that looks not so good also.
Even so, I think the old code would have worked by good luck - in the end $dhcpv6leaseinlocaltime is only compared to "yes" anyway, so if it ended up as unset, or some part of a sub-array of $config['dhcpdv6'] or... it still functioned like "no".
I found this by a quick scan through the output of:
find /usr -type f -exec grep -H "^[^(]*==" {} \;
That returns a lot of other stuff, but the bad uses of "==" stand out.

  • added
  • modified
  • copied
  • renamed
  • deleted