Project

General

Profile

« Previous | Next » 

Revision cba2816e

Added by NOYB NOYB over 9 years ago

Form Group - Empty Title GetText

Don't call gettext with an empty title.

There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.

Fixes use case of form group class without a title from passing empty var to gettext.
Gettext returns header info. when an empty string/var is passed.

Perhaps a function should be created for this for consistency.
http://php.net/manual/en/function.gettext.php#108594

For groups without a title gettext returns header info.

To reproduce the issue select a non English language and open any of the following:
Services Load Balancer - edit
Diagnostics - Backup/Restore
Diagnostics - Status SMART
Status - System Logs - log filter and manage log panels
(not a comprehensive list)

  • added
  • modified
  • copied
  • renamed
  • deleted