pfSense

Whoops - we still need xmlrpc_value_to_php :P

Remove duplicate code (still trying to figure out exactly why we need $optcfg - this helps clean it up a bit)

rmdir_recursive: Check that the specified directories actually exist before trying to remove them.

Remove ipfilter-ism - pf doesn't use groups

We're a function being called in a loop, return instead of continue

Do not assign a LABEL to a nonexistant rule

Add function to change XMLRPC values to their PHP equivalents.

XXX: xmlrpc_value_to_php does not currently handle structs.

Move user filter generation to it's own function (all 300+ lines of it!) - still needs cleanup, but output is unchanged

No need to loop through the shaper rules when creating filter rules - we don't tie them together
Remove TOS flag too - we don't do that either (maybe we should? 4 lines of code, no biggy - more helpful for assigning traffic to queues which....we don't do :))

no uses for $i found - a few commented out printf's - removed