Project

General

Profile

« Previous | Next » 

Revision fd86d829

Added by Cristian Feldman about 13 years ago

Overcome laziness to avoid unnecessary loop

View differences:

usr/local/www/firewall_aliases_edit.php
172 172
	$final_address_details = array();
173 173
	$alias['name'] = $_POST['name'];
174 174

  
175
	for($x=0; isset($_POST['address'.$x]); $x++) {
176
		$_POST['address'.$x] = trim($_POST['address'.$x]);
177
	}
178

  
179 175
	if ($_POST['type'] == "urltable") {
180 176
		$address = "";
181 177
		$isfirst = 0;
......
183 179
		/* item is a url type */
184 180
		if ($_POST['address0']) {
185 181
			/* fetch down and add in */
182
			$_POST['address0'] = trim($_POST['address0']);
186 183
			$isfirst = 0;
187 184
			$address = "";
188 185
			$alias['url'] = $_POST['address0'];
......
200 197
		$address_count = 2;
201 198

  
202 199
		/* item is a url type */
203
		for($x=0; isset($_POST['address'. $x]); $x++) {
200
		for($x=0; isset($_POST['address' . $x]); $x++) {
201
			$_POST['address' . $x] = trim($_POST['address' . $x]);
204 202
			if($_POST['address' . $x]) {
205 203
				/* fetch down and add in */
206 204
				$isfirst = 0;
......
254 252
		$wrongaliases = "";
255 253
		for($x=0; $x<4999; $x++) {
256 254
			if($_POST["address{$x}"] <> "") {
255
				$_POST["address{$x}"] = trim($_POST["address{$x}"]);
257 256
				if (is_alias($_POST["address{$x}"])) {
258 257
					if (!alias_same_type($_POST["address{$x}"], $_POST['type']))
259 258
						// But alias type network can include alias type urltable. Feature#1603.

Also available in: Unified diff