Project

General

Profile

Actions
Copy link

Bug #10001

closed

incorrect route deletion on 2.5

Added by Viktor Gurov almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Routing
Target version:
2.5.0
Start date:
12/28/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.5.0
Affected Architecture:

Description

All code that uses “delete route” must use the full format with GW, i.e.

incorrect:

# route delete -inet 5.5.5.0/24
route: route has not been found
delete net 5.5.5.0 fib 0: not in table

correct:

# route delete -inet 5.5.5.0/24 10.1.0.254
delete net 5.5.5.0: gateway 10.1.0.254

no such issue with 2.4.4-p3 and 2.4.5
it seems FreeBSD 12 issue

Same issue as https://redmine.pfsense.org/issues/9969

Actions
Copy link
 #2

Updated by Viktor Gurov almost 5 years ago

no such issue on clean FreeBSD 12.1

need to test on clean FreeBSD 12.0
is there any special patches in pfSense 2.5?..

Actions
Copy link
 #3

Updated by Jim Pingle almost 5 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

It is possible this may fix itself once we move to a 12.1 base, it may be a problem specific to 12.0.

Actions
Copy link
 #4

Updated by Viktor Gurov almost 5 years ago

Jim Pingle wrote:

It is possible this may fix itself once we move to a 12.1 base, it may be a problem specific to 12.0.

Tested on clean FreeBSD 12.0 - no such issue
it seems pfSense specific (special patches for routing/FIB ?)

In any case it is more correct use full syntax (with $gateway),
because you can have few routes (created in different ways - static route, General Setup / DNS, FRR) to the same destination,
and the 'old way' will delete them all

Actions
Copy link
 #5

Updated by Renato Botelho almost 5 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions
Copy link
 #6

Updated by Viktor Gurov almost 5 years ago

Renato Botelho wrote:

PR has been merged. Thanks!

same fix for system.php:
https://github.com/pfsense/pfsense/pull/4158

Actions
Copy link
 #7

Updated by Renato Botelho almost 5 years ago

Viktor Gurov wrote:

Renato Botelho wrote:

PR has been merged. Thanks!

same fix for system.php:
https://github.com/pfsense/pfsense/pull/4158

Merged

Actions
Copy link
 #8

Updated by Jim Pingle almost 5 years ago

  • Status changed from Feedback to Pull Request Review
Actions
Copy link
 #9

Updated by Renato Botelho almost 5 years ago

  • Status changed from Pull Request Review to Feedback

2nd PR was merged

Actions
Copy link
 #10

Updated by Viktor Gurov almost 5 years ago

  • Status changed from Feedback to Resolved

works as expected on 2.5.0.a.20200219.1144

Actions
Copy link

Also available in: Atom PDF