Project

General

Profile

Bug #10224

DHCP DDNS does not add zone entries for keys when using static host DDNS definitions

Added by Andreas Bleischwitz about 2 months ago. Updated about 2 months ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
-
Category:
DHCP Server
Target version:
-
Start date:
01/31/2020
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.4.4-p3
Affected Architecture:
All

Description

The current implementation of dhcpdzones() in etc/inc/services.inc does not take the per host defined ddns zone and related keys into account, resulting in a unexpected behaviour of DHCP.

This seem to be caused by $sm['domain'] of services_dhcpdv4_configure() not being added to $ddns_zones[] in the loop foreach ($dhcpifconf['staticmap'] as $sm) {.

The resulting configuration file /var/dhcpd/etc/dhcpd.conf does not list any of the defined ddns-zones of a static defined host in the zone section containing a key. As of this, an external DNS would not get updated on client registrations.

History

#1 Updated by Andreas Bleischwitz about 2 months ago

By further looking at the code, I get the feeling that the configuration for DHCP should be made modular.
Currently the configuration of each interface is parsed and the configuration options for DHCP are build based on the settings.

Most of those settings are also given for a static mapping, but some of them are ignored. And they are parsed in a different loop which duplicates code maintenance.

Creating a generic DHCP parser for DHCP-options could be applicable for general options and static-host options.

This is just an idea.

#3 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review

Also available in: Atom PDF