Project

General

Profile

Actions

Bug #10247

closed

Duplicate Outbound NAT entries when creating L2TP server

Added by James L over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Category:
Rules / NAT
Target version:
Start date:
02/09/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4-p3
Affected Architecture:

Description

When enabling and configuring the L2TP server, I noticed that it creates duplicate entries in outbound NAT for the remote address subnet.

Per this forum thread: https://forum.netgate.com/topic/150290/duplicate-outbound-nat-entries-when-creating-l2tp-server Jim Pingle suggested this might be unintended duplication:

Looks like there may be an unintended duplication there.

It gets added to $FilterIflist at https://github.com/pfsense/pfsense/blob/master/src/etc/inc/filter.inc#L1179

And then manually added to the NAT network list at https://github.com/pfsense/pfsense/blob/master/src/etc/inc/filter.inc#L1664

I've attached screenshots attached showing issue.

This occurs in 2.4.4-p3, 2.4.5-RC and 2.5.0


Files

pfsense1.png (25.2 KB) pfsense1.png L2TP server config James L, 02/09/2020 02:44 PM
pfsense2.png (23.2 KB) pfsense2.png Automatic outbound NAT rules James L, 02/09/2020 02:44 PM
pfsense3.png (23.6 KB) pfsense3.png Changed to manual rules James L, 02/09/2020 02:44 PM
Actions #1

Updated by Jim Pingle over 2 years ago

  • Category set to Rules / NAT
  • Assignee set to Jim Pingle
  • Priority changed from Normal to Very Low
  • Target version set to 2.5.0

Setting to 2.5.0 since it's harmless/cosmetic.

Actions #3

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
Actions #4

Updated by Renato Botelho about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Viktor Gurov about 2 years ago

  • Status changed from Feedback to Resolved

now it's ok on 2.5.0.a.20200423.1513

Actions #6

Updated by Jim Pingle about 2 years ago

  • Status changed from Resolved to Feedback
  • Target version changed from 2.5.0 to 2.4.5-p1

Original commit is 8f74c44e459e7f9c3d6559bee5d9ca1e49694852

Picked back in ba77c38370

Actions #7

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved

L2TP server subnet(s) are only listed once in outbound NAT now.

Actions

Also available in: Atom PDF