pfSense

filter.inc
Function discover_pkg_rules

Symptoms:
Errors in syslog
check_reload_status: syncing firewall
php: : The command '/sbin/pfctl -nf /tmp/rules.test.packages' returned exit code '1', the output was '/tmp/rules.test.packages:17: syntax error /tmp/rules.test.packages:18: syntax error'
php: : There was an error while parsing the package filter rules for /usr/local/pkg/havp.inc.

This message exists even havp_generate_rules returned empty string.

Bug:
$status = mwexec("/sbin/pfctl -nf {$g['tmp_path']}/rules.test.packages");
if ($status <> 0) {

In this code $status contains not-numeric value "0", and expression ($status <> 0) always TRUE, becose comparing different types.
Maybe good idea convert $status to the numeric type ?