Project

General

Profile

Actions

Bug #10305

closed

Using special character in Schedules description

Added by Viktor Gurov about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
02/29/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4-p3
Affected Architecture:

Description

When using special characters in Schedules and timeranges description fields
firewall_schedule.php page shows escaping symbols, i.e.
Günter instead of Günter

Actions #1

Updated by Viktor Gurov about 2 years ago

Günter instead of Günter

This PR removes htmlentities($_POST['descr'], ENT_QUOTES, 'UTF-8'); (legacy code?)
from firewall_schedule_edit.php
and adds rangedescr to $cdata_fields array
It also sort $cdata_fields array alphabetically

https://github.com/pfsense/pfsense/pull/4214

Actions #2

Updated by Viktor Gurov about 2 years ago

  • Affected Version set to 2.4.4-p3
Actions #3

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
Actions #4

Updated by Renato Botelho about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.5.0
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Viktor Gurov about 2 years ago

  • Status changed from Feedback to Resolved

OK on 2.5.0.a.20200317.1949

Actions #6

Updated by Jim Pingle about 2 years ago

  • Status changed from Resolved to Feedback
  • Target version changed from 2.5.0 to 2.4.5-p1
Actions #7

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved

GUI looks good with the supplied test string. Descriptions show the expected string, and when editing the schedule, the expected string is in the fields without extra escaping.

Actions

Also available in: Atom PDF