Project

General

Profile

Bug #10390

Fix DigitalOcean Dynamic DNS client for IPv6

Added by Csoban Kesmarki 2 months ago. Updated 9 days ago.

Status:
Resolved
Priority:
Normal
Category:
Dynamic DNS
Target version:
Start date:
03/29/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
Affected Architecture:

Description

The DigitalOcean IPv6 Dynamic DNS Client could not find the proper IPv6 entry when updating and fails with the error message from DigitalOcean service:
'{"id":"unprocessable_entity","message":"record content is invalid: ipv4 address is invalid"}'

Associated revisions

Revision 08939cfb (diff)
Added by Csoban Kesmarki about 2 months ago

DigitalOcean IPv6 DDNS Client to find IPv6 entries when updating. Issue #10390

-[] Redmine Issue: https://redmine.pfsense.org/issues/10390

-[] Ready for review

Revision 42d3d5fc (diff)
Added by Csoban Kesmarki about 2 months ago

DigitalOcean IPv6 DDNS Client to find IPv6 entries when updating. Issue #10390

-[] Redmine Issue: https://redmine.pfsense.org/issues/10390

-[] Ready for review

(cherry picked from commit 08939cfbc054fcaed03a3128b673b2db592cc2ad)

History

#1 Updated by Csoban Kesmarki 2 months ago

The corresponding line causes the failure is in /etc/in/dyndns.class, line 1054 (in pfSense v2.4.5 RELEASE):
if ($this->_dnsHost $dnsRecord->name && $dnsRecord->type 'A') {

Suggesting instead:
if ($this->_dnsHost $dnsRecord->name && $dnsRecord->type ($isv6 ? 'AAAA' : 'A')) {

If accepted, I will raise a pull request for this.

#2 Updated by Jim Pingle 2 months ago

  • Category set to Dynamic DNS
  • Target version set to 2.5.0

Can you submit that change as a pull request on Github?

https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html

Thanks!

#4 Updated by Jim Pingle 2 months ago

  • Status changed from New to Pull Request Review

#6 Updated by Renato Botelho about 2 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#7 Updated by Jim Pingle about 1 month ago

  • Target version changed from 2.5.0 to 2.4.5-p1

#8 Updated by Jim Pingle 13 days ago

  • Status changed from Feedback to Resolved

New code is present. No direct way to test without an account, but the logic looks sound.

#9 Updated by Csoban Kesmarki 9 days ago

A note for testing: I'm using this modified code on my 2.4.5 as a patch since 3/29/2020 without any issue.

Also available in: Atom PDF