Bug #10390
closed
Fix DigitalOcean Dynamic DNS client for IPv6
100%
Description
The DigitalOcean IPv6 Dynamic DNS Client could not find the proper IPv6 entry when updating and fails with the error message from DigitalOcean service:
'{"id":"unprocessable_entity","message":"record content is invalid: ipv4 address is invalid"}'
Updated by Csoban Kesmarki over 4 years ago
The corresponding line causes the failure is in /etc/in/dyndns.class, line 1054 (in pfSense v2.4.5 RELEASE):
if ($this->_dnsHost $dnsRecord->name && $dnsRecord->type 'A') {
Suggesting instead:
if ($this->_dnsHost $dnsRecord->name && $dnsRecord->type ($isv6 ? 'AAAA' : 'A')) {
If accepted, I will raise a pull request for this.
Updated by Jim Pingle over 4 years ago
- Category set to Dynamic DNS
- Target version set to 2.5.0
Can you submit that change as a pull request on Github?
https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html
Thanks!
Updated by Csoban Kesmarki over 4 years ago
Yes sir, just did: https://github.com/pfsense/pfsense/pull/4259
Updated by Jim Pingle over 4 years ago
- Status changed from New to Pull Request Review
Updated by Csoban Kesmarki over 4 years ago
Corrected pull request: https://github.com/pfsense/pfsense/pull/4268
Updated by Renato Botelho over 4 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
Updated by Jim Pingle over 4 years ago
- Target version changed from 2.5.0 to 2.4.5-p1
Updated by Jim Pingle over 4 years ago
- Status changed from Feedback to Resolved
New code is present. No direct way to test without an account, but the logic looks sound.
Updated by Csoban Kesmarki over 4 years ago
A note for testing: I'm using this modified code on my 2.4.5 as a patch since 3/29/2020 without any issue.