Project

General

Profile

Actions

Bug #10390

closed

Fix DigitalOcean Dynamic DNS client for IPv6

Added by Csoban Kesmarki about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
Dynamic DNS
Target version:
Start date:
03/29/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

The DigitalOcean IPv6 Dynamic DNS Client could not find the proper IPv6 entry when updating and fails with the error message from DigitalOcean service:
'{"id":"unprocessable_entity","message":"record content is invalid: ipv4 address is invalid"}'

Actions #1

Updated by Csoban Kesmarki about 2 years ago

The corresponding line causes the failure is in /etc/in/dyndns.class, line 1054 (in pfSense v2.4.5 RELEASE):
if ($this->_dnsHost $dnsRecord->name && $dnsRecord->type 'A') {

Suggesting instead:
if ($this->_dnsHost $dnsRecord->name && $dnsRecord->type ($isv6 ? 'AAAA' : 'A')) {

If accepted, I will raise a pull request for this.

Actions #2

Updated by Jim Pingle about 2 years ago

  • Category set to Dynamic DNS
  • Target version set to 2.5.0

Can you submit that change as a pull request on Github?

https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html

Thanks!

Actions #4

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
Actions #6

Updated by Renato Botelho about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #7

Updated by Jim Pingle about 2 years ago

  • Target version changed from 2.5.0 to 2.4.5-p1
Actions #8

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved

New code is present. No direct way to test without an account, but the logic looks sound.

Actions #9

Updated by Csoban Kesmarki almost 2 years ago

A note for testing: I'm using this modified code on my 2.4.5 as a patch since 3/29/2020 without any issue.

Actions

Also available in: Atom PDF