Project

General

Profile

Actions

Bug #10499

closed

Dark theme Auto-complete popup field has dark text on dark background

Added by Marc 05 over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
04/25/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

Using pfSense-dark.css, the auto-complete pop-up currently does not specify a background image. This leads to theme.css applying a dark background image. Given the font color is also a dark color, this makes the text hard to read.

This can be fixed by setting background-image to none for ".ui-autocomplete". E.g.:
/** Styling for jQuery autocomplete widget */
.ui-autocomplete {
color: #212121;
background-color: #e0e0e0;
background-image: none;
}

See attached for example screenshots.


Files

bug.png (133 KB) bug.png Marc 05, 04/25/2020 11:57 AM
fix.png (163 KB) fix.png Marc 05, 04/25/2020 11:57 AM
Actions #1

Updated by Jim Pingle over 1 year ago

  • Target version set to 2.5.0
  • Affected Version set to All
Actions #2

Updated by Jim Pingle over 1 year ago

  • Status changed from New to Pull Request Review
Actions #3

Updated by Marc 05 over 1 year ago

@Jim

Thanks for your patience!

Actions #4

Updated by Renato Botelho over 1 year ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Jim Pingle over 1 year ago

  • Target version changed from 2.5.0 to 2.4.5-p1
Actions #6

Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to Resolved

When using the dark theme, the autocomplete drop-down now has a light background and text is easy to read.

Actions

Also available in: Atom PDF