Project

General

Profile

Bug #10647

FRR BGP Advanced > Aggregated Addresses ignores ipv6 subnets

Added by Max Maton 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Category:
FRR
Target version:
-
Start date:
06/09/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
Affected Architecture:
All

Description

The php script generating the bgp.conf file only writes out the configuration if the subnet is an ipv4 subnet: https://github.com/pfsense/FreeBSD-ports/blob/9fdee68a7df90cab70451ac684e2a8b21d824b08/net/pfSense-pkg-frr/files/usr/local/pkg/frr/inc/frr_bgp.inc#L286

Adding this below the block that writes out the ipv4 aggregations fixes the issue:

        $advconf .= "address-family ipv6 unicast\n";
        /* Aggregate Behavior */
        foreach ($frr_bgpadv_conf['row'] as $aggr) {
                if (is_subnetv6($aggr['aggregateaddr'])) {
                        $advconf .= "    aggregate-address {$aggr['aggregateaddr']}";
                        if (!empty($aggr['aggregateasset'])) {
                                $advconf .= " as-set";
                        }
                        if (!empty($aggr['aggregatesummaryonly'])) {
                                $advconf .= " summary-only";
                        }
                        $advconf .= "\n";
                }
        }
        $advconf .= "exit-address-family\n";

History

#2 Updated by Jim Pingle 2 months ago

  • Status changed from New to Pull Request Review

#3 Updated by Renato Botelho 2 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Viktor Gurov about 1 month ago

  • Status changed from Feedback to Resolved

works as expected:

/var/etc/frr/bgpd.conf:
# BGP Config
router bgp 65001
  address-family ipv4 unicast
   aggregate-address 192.168.0.0/16
  exit-address-family 
  address-family ipv6 unicast
   aggregate-address fc00:1234::/64
   distance 44 fc00:4444::/64
  exit-address-family

Also available in: Atom PDF