Project

General

Profile

Bug #10847

Mobile user IPSec (PSK+Xauth) fails at user auth with PHP error

Added by James Cooksey 2 months ago. Updated 15 days ago.

Status:
Resolved
Priority:
Very High
Category:
IPsec
Target version:
Start date:
08/22/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.5.0
Affected Architecture:
All

Description

amd64
12.1-STABLE
FreeBSD 12.1-STABLE b385628d96e(devel-12) pfSense

Crash report details:

PHP Errors:
[21-Aug-2020 18:37:05 Etc/Greenwich] PHP Fatal error: Uncaught Error: Cannot pass parameter 3 by reference in /etc/inc/ipsec.auth-user.php:95
Stack trace:
#0 {main}
thrown in /etc/inc/ipsec.auth-user.php on line 95

Fixed by chaging:

$userGroups = getUserGroups($username, $authcfg, array());

to

$userGroups = getUserGroups($username, $authcfg, $attributes = array());

Pull request: https://github.com/pfsense/pfsense/pull/4429

History

#1 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review
  • Assignee deleted (James Cooksey)

#2 Updated by Renato Botelho about 2 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#3 Updated by Steve Beaver 15 days ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF