Project

General

Profile

Actions
Copy link

Feature #1086

closed

[patch] CARP IPs as outer source addressed for GRE and GIF tunnels

Added by Fulvio Scapin almost 14 years ago. Updated almost 14 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Interfaces
Target version:
2.0
Start date:
12/09/2010
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

I applied the code from the ipsec/openvpn interface lists to include CARP VIP interfaces as outer source addresses for GRE/GIF interfaces.
It is of high importance in order to tunnel dynamic routing information exchanges.
The patch is as follows.

diff --git a/usr/local/www/interfaces_gif_edit.php b/usr/local/www/interfaces_gif_edit.php
index efbf036..e66bbc5 100644
--- a/usr/local/www/interfaces_gif_edit.php
+++ b/usr/local/www/interfaces_gif_edit.php
@@ -136,6 +136,9 @@ include("head.inc");
                     <select name="if" class="formselect">
                       <?php
                                                $portlist = get_configured_interface_with_descr();
+                                               $carplist = get_configured_carp_interface_list();
+                                               foreach ($carplist as $cif => $carpip)
+                                                       $portlist[$cif] = $carpip." (".get_vip_descr($carpip).")";
                                                foreach ($portlist as $ifn => $ifinfo) {
                                                        echo "<option value=\"{$ifn}\"";
                                                        if ($ifn == $pconfig['if'])
diff --git a/usr/local/www/interfaces_gre_edit.php b/usr/local/www/interfaces_gre_edit.php
index f0f0a84..ce9f324 100644
--- a/usr/local/www/interfaces_gre_edit.php
+++ b/usr/local/www/interfaces_gre_edit.php
@@ -139,6 +139,9 @@ include("head.inc");
                     <select name="if" class="formselect">
                       <?php
                                                $portlist = get_configured_interface_with_descr();
+                                               $carplist = get_configured_carp_interface_list();
+                                               foreach ($carplist as $cif => $carpip)
+                                                       $portlist[$cif] = $carpip." (".get_vip_descr($carpip).")";
                                                foreach ($portlist as $ifn => $ifinfo) {
                                                        echo "<option value=\"{$ifn}\"";
                                                        if ($ifn == $pconfig['if'])

The code is also present in the repository/branch trantorvega-clone/carp_tunnels at rcs.pfsense.org

PS I've been told that the "merge requests" feature at rcs.pfsense.org was broken. Is that still the case?

Actions
Copy link

Also available in: Atom PDF