Project

General

Profile

Bug #1090

clean up interfaces mess in setup wizard

Added by Chris Buechler over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Interfaces
Target version:
Start date:
12/10/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

Revision 389c778ec29d929a17843139f8cddf337b8fa9ad by gnhb added an interface drop down to the WAN configuration page in the setup wizard, which breaks the WAN assignment when it's anything but a physical interface (example: VLAN) when the wizard is run or re-run. That box just needs to go away, there is no need to change the interface assignment at that point.

Jim also noted bad usage of a temp variable under $config in the <stepbeforeformdisplay>

Associated revisions

Revision 841c4125 (diff)
Added by Marcus Brown over 8 years ago

Remove dropdown to select interface. Should fix #1090

History

#1 Updated by Marcus Brown over 8 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Marcus Brown over 8 years ago

Committed the removal of the dropdown interfaces select box.

About the temp variable, I couldn't really figure out how to store temporary data in the wizard code, so I stored it under $config because that's the only place I could tell that the wizard is designed to put data that is entered on the php form, and I didn't feel qualified or authorized to re-write the structure of the wizard. If anyone knows a better way, please fix it.

#3 Updated by Erik Fonnesbeck over 8 years ago

As far as I could tell, it doesn't end up writing that to the config between those steps, but it would probably be better to at least put that temporary item in a different section just in case, because nothing other than wan, lan, and opt# sections are supposed to be in interfaces.

#4 Updated by Marcus Brown over 8 years ago

This is probably obvious, but the Setup Wizard will silently fail to create a valid PPPoE or PPTP link if the WAN is not already assigned to the correct parent interface for the PPPoE/PPTP link. That's why I added the interface select list in the first place.

#5 Updated by Erik Fonnesbeck over 8 years ago

It is assumed that the port for your WAN connection is already assigned to WAN before the setup wizard is even started, either by having plugged the cable into the correct port or by assigning the correct port during interface assignment on the console (or interface assignment in the web gui if running the setup wizard again later).

#6 Updated by Ermal Lu├ži over 8 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF