Bug #10998: traffic shaper php error - pfSense - pfSense bugtracker

Actions

Copy link

Bug #10998

closed

traffic shaper php error

Added by Michael Kellogg about 4 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Viktor Gurov

Category:

Traffic Shaper (ALTQ)

Target version:

2.5.0

Start date:

10/21/2020

Due date:

% Done:

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.5.0

Affected Architecture:

Description

2.5.0-DEVELOPMENT (amd64)
built on Tue Oct 20 13:03:46 EDT 2020
FreeBSD 12.2-STABLE
Crash report begins. Anonymous machine information:

amd64
12.2-STABLE
FreeBSD 12.2-STABLE c35168ee137(devel-12) pfSense

Crash report details:

PHP Errors:
[21-Oct-2020 13:47:17 America/New_York] PHP Fatal error: Uncaught Error: Call to undefined method hfsc_queue::GetScheduler() in /etc/inc/shaper.inc:1580
Stack trace:
#0 /etc/inc/shaper.inc(2282): priq_queue->validate_input(Array, NULL)
#1 /etc/inc/shaper.inc(2123): hfsc_queue->validate_input(Array, NULL)
#2 /etc/inc/shaper.inc(909): hfsc_queue->add_queue('opt1', Array, Array, NULL)
#3 /etc/inc/shaper.inc(5139): altq_root_queue->add_queue('opt1', Array, Array, NULL)
#4 /usr/local/www/firewall_shaper.php(48): read_altq_config()
#5 {main}
thrown in /etc/inc/shaper.inc on line 1580

No FreeBSD crash data found.

Actions

Copy link

Updated by Jim Pingle about 4 years ago

Category set to Traffic Shaper (ALTQ)
Target version set to 2.5.0
Affected Version set to 2.5.0

Actions

Copy link

Updated by Viktor Gurov about 4 years ago

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/27

Actions

Copy link

Updated by Renato Botelho about 4 years ago

Status changed from New to Feedback
Assignee set to Viktor Gurov

PR has been merged. Thanks!

Actions

Copy link

Updated by Viktor Gurov about 4 years ago

Status changed from Feedback to Resolved

works as expected on 2.5.0.a.20201023.1850
now it's possible to create any number of nested queues without errors

Actions

Copy link

Updated by Niccolò Marchi about 4 years ago

amd64
12.2-STABLE
FreeBSD 12.2-STABLE 2841d41b090(devel-12) pfSense

Crash report details:

PHP Errors:
[01-Nov-2020 12:45:10 Europe/Rome] PHP Fatal error: Uncaught Error: Call to a member function GetScheduler() on null in /etc/inc/shaper.inc:1581
Stack trace:
#0 /etc/inc/shaper.inc(2283): priq_queue->validate_input(Array, NULL)
#1 /etc/inc/shaper.inc(902): hfsc_queue->validate_input(Array, NULL)
#2 /usr/local/www/wizards/traffic_shaper_wizard_multi_all.inc(876): altq_root_queue->add_queue(Object(hfsc_queue), Array, Array, NULL)
#3 /usr/local/www/wizards/traffic_shaper_wizard_multi_all.inc(697): apply_all_chosen_items()
#4 /usr/local/www/wizard.php(116) : eval()'d code(1): step8_stepsubmitphpaction()
#5 /usr/local/www/wizard.php(116): eval()
#6 {main}
thrown in /etc/inc/shaper.inc on line 1581