Project

General

Profile

Bug #11064

WARNING: write_config() was called without description

Added by Viktor Gurov 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Category:
Configuration Backend
Target version:
Start date:
11/13/2020
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.5.0
Affected Architecture:
Release Notes:
Default

Description

found some files with 'write_config()' without description:

/usr/local/www/haproxy/haproxy_pools.php:        if (write_config()) {
/usr/local/www/haproxy/haproxy_pools.php:        write_config();
/usr/local/www/haproxy/haproxy_global.php:            write_config();
/usr/local/www/status_mail_report_edit.php:        write_config();
/usr/local/www/status_mail_report_edit.php:        write_config();
/usr/local/www/status_mail_report_edit.php:    write_config();
/usr/local/www/status_mail_report_add_log.php:    write_config();
/usr/local/www/status_mail_report_add_cmd.php:    write_config();
/usr/local/www/firewall_nat.php.orig:        if (write_config()) {
/usr/local/www/firewall_nat.php.orig:        if (write_config()) {
/usr/local/www/firewall_nat.php.orig:        if (write_config()) {

History

#1 Updated by Renato Botelho 5 months ago

  • Status changed from New to In Progress
  • Assignee set to Renato Botelho
  • Target version set to 2.5.0

I've changed it on ports but didn't bump PORTREVISION so new packages were not built. I'll take care of that

#2 Updated by Renato Botelho 5 months ago

  • Status changed from In Progress to Feedback

Fixed.

#3 Updated by Danilo Zrenjanin 5 months ago

  • Status changed from Feedback to Resolved

tested on:

2.5.0-DEVELOPMENT (amd64)
built on Sat Nov 21 01:03:32 EST 2020
FreeBSD 12.2-STABLE

/usr/local/www/haproxy/haproxy_pools.php: if (write_config("HAProxy, deleting backend(s)")) {
/usr/local/www/haproxy/haproxy_pools.php: write_config("haproxy-devel: Pool deleted");
/usr/local/www/haproxy/haproxy_global.php: write_config("haproxy-devel: Global settings saved");
/usr/local/www/status_mail_report_edit.php: write_config("mailreport: Item deleted");
/usr/local/www/status_mail_report_edit.php: write_config("mailreport: Item saved");
/usr/local/www/status_mail_report_edit.php: write_config("mailreport: Settings updated");
/usr/local/www/firewall_nat.php: if (write_config("NAT: Rule order changed")) {
/usr/local/www/firewall_nat.php: if (write_config("NAT: Rule deleted")) {
/usr/local/www/firewall_nat.php: if (write_config(gettext("Firewall: NAT: Port forward, enable/disable NAT rule"))) {

Ticket resolved.

Also available in: Atom PDF