pfSense » pfSense Packages

Sorry "wan't been modified" -> "wasn't been modified" typo.

Fix:
https://gitlab.netgate.com/pfSense/FreeBSD-ports/-/merge_requests/18

Hi Viktor, can you please provide diff -u ? I can check fix and provide feedback. Thank you for fix and also wish you happy new year.

Hi Viktor, thank you. Fix for this bug working. Tested:
1. modified file without script action - another files actions not triggered.
2. created 2 test sh scripts via filer, each of them do echo to another files and action trigger them selfs. Saved one of them - second isn't triggered.

1. file permissions
2. content
3. file action type and content

and run action only if any of them was been changed compared to previous ones. E.g. like Ansible or Chef do, state: changed - trigger action, state: unchanged - no action taken :).

I think this both cases need dedicated issues. What you think?

DRago_Angel [InV@DER] wrote:

Hi Viktor, thank you. Fix for this bug working. Tested:
1. modified file without script action - another files actions not triggered.
2. created 2 test sh scripts via filer, each of them do echo to another files and action trigger them selfs. Saved one of them - second isn't triggered.

But found another 2 cases:
1. when you say filer create file for directory that not exists yet on pfSense - it not create this directory and of course not create file. Also here is question mark - we have file permissions settings, but not user and group owner, as well we do not have settings for folder, if we want create folder which is missing - we need know which permissions it must have. Need to track what last folder in path exist and not touch it permissions, create folders via mkdir -p to end, but do chown & chmod -R on first not existing folder before do chown and chmod on file.
2. when file not modified action still triggered, it would be cool to check:

1. file permissions
2. content
3. file action type and content

and run action only if any of them was been changed compared to previous ones. E.g. like Ansible or Chef do, state: changed - trigger action, state: unchanged - no action taken :).

I think this both cases need dedicated issues. What you think?

yes, please open new tickets for other issues.

Renato Botelho wrote:

PR has been merged. Thanks!

Hi, Thank you! I created new issues and also want ask you or Viktor to check in first time https://redmine.pfsense.org/issues/10426 this issue in filer, I think this one most easy to fix.