Bug #11407
Removing a WireGuard tunnel in a middle position can break Add button behavior
100%
Description
If there are three WireGuard tunnels (wg0, wg1, wg2) and the middle tunnel (wg1) is removed, the add button links to vpn_wg_edit.php?index=1
since it's trying to incorrectly treat the WireGuard interface number as an array index, which is no longer true. When the user clicks the Add button, it edits the second instance (array index 1) which is now wg2, and does not create a new entry.
Similar to #11323
As a workaround, the user can manually change the URL to remove the index number (e.g. go right to vpn_wg_edit.php
with no parameters)
To me, I'm working up a fix.
Associated revisions
Fix WireGuard add/next name behavior. Fixes #11407
- No need to set index when creating a new entry
- WireGuard interface name label was assuming array index=wg if name
which was incorrect
(cherry picked from commit 11fd7da72502c991b1f1c0e886ea212235f4a505)
History
#1
Updated by Jim Pingle 2 months ago
- Description updated (diff)
#2
Updated by Jim Pingle 2 months ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 11fd7da72502c991b1f1c0e886ea212235f4a505.
#3
Updated by Jim Pingle about 1 month ago
- Target version changed from CE-Next to 2.5.1
#4
Updated by Alhusein Zawi about 1 month ago
- Status changed from Feedback to Resolved
fixed.
Adding/removing WireGuard tunnels have been done without any issue.
2.5.1-RC (amd64)
built on Thu Mar 11 09:11:02 EST 2021
#5
Updated by Jim Pingle 28 days ago
- Target version changed from 2.5.1 to Future
#6
Updated by Jim Pingle 28 days ago
- Status changed from Resolved to Waiting on Merge
Fix WireGuard add/next name behavior. Fixes #11407
which was incorrect