Project

General

Profile

Actions
Copy link

Regression #11510

closed

ARP Table populates hostname values using expired DHCP lease data

Added by Tomasz K. over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jim Pingle
Category:
Diagnostics
Target version:
2.5.2
Start date:
02/23/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:
amd64

Description

Description based on discussion from https://forum.netgate.com/topic/161139/arp-bug-pfsense-2-5-0

In Diagnostic -> ARP Table sometimes you can find wrong values in Hostname column. For me it happens only for addresses which currently are static but some time ago were assigned by DHCP - in hostname column I get IP from the time when it wasn't static.

I opened diag_arp.inc and it looks that function system_get_dhcpleases (called in prepare_ARP_table) is returning double entries for one mac:

  • old: with "type" = "dynamic", "act" = "expired" and "online" = "offline"
  • new: with "type" = "static", "act" = "static" and "online" = "online"

But I don't know if this the only possible scenario that will give wrong results.

As an experiment I made diff (based on v2.5.0 git tag and attached to this issue) and at least host name column looks good but I don't have enough knowledge to tell if this is correct solution. But maybe it will point somebody to proper fix.

Files

diag_arp.inc.diff (590 Bytes) diag_arp.inc.diff experimental fix Tomasz K., 02/23/2021 11:34 AM
Actions
Copy link
 #1

Updated by Jim Pingle over 3 years ago

  • Tracker changed from Bug to Regression
  • Target version set to CE-Next
Actions
Copy link
 #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Jim Pingle
  • Target version changed from CE-Next to 2.6.0

I was able to reproduce this. I used a slightly different fix.

Actions
Copy link
 #3

Updated by Jim Pingle over 3 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Jim Pingle over 3 years ago

  • Plus Target Version set to 21.05
Actions
Copy link
 #5

Updated by Jim Pingle over 3 years ago

Already in 21.05 branch.

Actions
Copy link
 #6

Updated by Jim Pingle over 3 years ago

  • Subject changed from ARP Table - hostname taken from expired leases to ARP Table populates hostname values using expired DHCP lease data
  • Category changed from Web Interface to Diagnostics

Updating subject for release notes.

Actions
Copy link
 #7

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Closed

This looks good on current builds on the system where I could reproduce it before.

Actions
Copy link
 #8

Updated by Jim Pingle over 3 years ago

  • Target version changed from 2.6.0 to 2.5.2
Actions
Copy link

Also available in: Atom PDF