Project

General

Profile

Regression #11519

Incorrect DHCP failover IP address configured on peer after XMLRPC sync

Added by Viktor Gurov about 2 months ago. Updated about 1 month ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
XMLRPC
Target version:
Start date:
02/24/2021
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.5.0
Affected Architecture:
Release Notes:
Default

Description

`/etc/rc.filter_synchronize` uses `guess_interface_from_ip()` which returns only first (top-down) interface from the `route_get($ipaddress)` output (which is slow, see #11475)

how to reproduce:
1) LAN (vtnet0) - 192.168.88.41/24, used for DHCP (failover IP on secondary - 192.168.88.42);
2) Create OpenVPN p2p instance with remote network 192.168.0.0/16;

now `guess_interface_from_ip("192.168.88.42")` returns 'ovpns1', cause it first in the `netstat -rn` output:

netstat -rn | grep 192.168.
192.168.0.0/16     10.78.78.2         UGS      ovpns2
192.168.88.0/24    link#1             U        vtnet0
192.168.88.41      link#1             UHS         lo0

see https://forum.netgate.com/topic/161152/strange-problem-dhcp-failover-after-upgrade-to-2-5-0-xmlrpc-bug

Associated revisions

Revision 490b5b48 (diff)
Added by Viktor Gurov about 1 month ago

Set correct DHCP failover peer IP on XMLRPC sync. Fixes #11519

Revision 82690894 (diff)
Added by Viktor Gurov about 1 month ago

Set correct DHCP failover peer IP on XMLRPC sync. Fixes #11519

(cherry picked from commit 490b5b480f1b46a6f93e0ba99fff578a61f3293c)

History

#2 Updated by Jim Pingle about 2 months ago

  • Tracker changed from Bug to Regression
  • Target version set to CE-Next

#3 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review

#4 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

#5 Updated by Viktor Gurov about 1 month ago

  • % Done changed from 0 to 100

#6 Updated by Jim Pingle about 1 month ago

  • Status changed from Feedback to Waiting on Merge
  • Target version changed from CE-Next to 2.5.1

#7 Updated by Renato Botelho about 1 month ago

  • Status changed from Waiting on Merge to Feedback

Cherry-picked to RELENG_2_5_1

#8 Updated by Jim Pingle about 1 month ago

  • Subject changed from Incorrect DHCP failover IP on XMLRPC sync to Incorrect DHCP failover IP address configured on peer after XMLRPC sync

Updating subject for release notes.

Also available in: Atom PDF