Project

General

Profile

Actions
Copy link

Regression #11519

closed
VG VG

Incorrect DHCP failover IP address configured on peer after XMLRPC sync

Regression #11519: Incorrect DHCP failover IP address configured on peer after XMLRPC sync

Added by Viktor Gurov over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Viktor Gurov
Category:
XMLRPC
Target version:
2.5.1
Start date:
02/24/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:

Description

`/etc/rc.filter_synchronize` uses `guess_interface_from_ip()` which returns only first (top-down) interface from the `route_get($ipaddress)` output (which is slow, see #11475)

how to reproduce:
1) LAN (vtnet0) - 192.168.88.41/24, used for DHCP (failover IP on secondary - 192.168.88.42);
2) Create OpenVPN p2p instance with remote network 192.168.0.0/16;

now `guess_interface_from_ip("192.168.88.42")` returns 'ovpns1', cause it first in the `netstat -rn` output:

netstat -rn | grep 192.168.
192.168.0.0/16     10.78.78.2         UGS      ovpns2
192.168.88.0/24    link#1             U        vtnet0
192.168.88.41      link#1             UHS         lo0

see https://forum.netgate.com/topic/161152/strange-problem-dhcp-failover-after-upgrade-to-2-5-0-xmlrpc-bug

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #2

  • Tracker changed from Bug to Regression
  • Target version set to CE-Next

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #3

  • Status changed from New to Pull Request Review

RB Updated by Renato Botelho over 5 years ago Actions
Copy link
 #4

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

VG Updated by Viktor Gurov over 5 years ago Actions
Copy link
 #5

  • % Done changed from 0 to 100

Applied in changeset commit:490b5b480f1b46a6f93e0ba99fff578a61f3293c.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #6

  • Status changed from Feedback to Waiting on Merge
  • Target version changed from CE-Next to 2.5.1

RB Updated by Renato Botelho over 5 years ago Actions
Copy link
 #7

  • Status changed from Waiting on Merge to Feedback

Cherry-picked to RELENG_2_5_1

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #8

  • Subject changed from Incorrect DHCP failover IP on XMLRPC sync to Incorrect DHCP failover IP address configured on peer after XMLRPC sync

Updating subject for release notes.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #9

  • Status changed from Feedback to Closed
Actions
Copy link

Also available in: Atom