Bug #11725
closed
Error when setting queue limit on CODELQ limiter
0%
Description
When applying a queue limit, it seems the queue size isn't applied.
Also the flowing error is thrown:
Filter Reload
There were error(s) loading the rules: /tmp/rules.debug:44: syntax error - The line in question reads [44]: altq on igb1 codelq ( qlimit 100 ) bandwidth 8500Kb queue
See attachement for screencapture.
Files
Updated by Viktor Gurov over 3 years ago
- Status changed from New to Confirmed
Updated by Viktor Gurov over 3 years ago
extra input validation:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/206
Updated by Vincent Jansen over 3 years ago
Viktor Gurov wrote:
extra input validation:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/206
Hi Viktor,
Thanks for taking this up. For some reason I cannot access your pull-request.
Being a developer myself, are you sure that input validation is the way we should go about this?
Perhaps it would make more sense to remove the fields when a certain limiter is selected from the dropdown and with/without postback provide the optional fields.
I'm not a Pfsense developer and therefore I trust your justment. Just throwing it out there.
Updated by Jim Pingle over 3 years ago
- Subject changed from Setting Queue Limit causes error to Error when setting queue limit on CODELQ limiter
- Status changed from Confirmed to Pull Request Review
- Target version set to CE-Next
Updated by Jim Pingle over 3 years ago
- Status changed from Pull Request Review to Feedback
- Target version changed from CE-Next to 2.6.0
PR was merged yesterday.
Updated by Jim Pingle over 3 years ago
- Target version changed from 2.6.0 to 2.5.2
Updated by