Project

General

Profile

Actions

Bug #11725

closed

Error when setting queue limit on CODELQ limiter

Added by Vincent Jansen 7 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Traffic Shaper (Limiters)
Target version:
Start date:
03/24/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:
All

Description

When applying a queue limit, it seems the queue size isn't applied.
Also the flowing error is thrown:

Filter Reload
There were error(s) loading the rules: /tmp/rules.debug:44: syntax error - The line in question reads [44]: altq on igb1 codelq ( qlimit 100 ) bandwidth 8500Kb queue

See attachement for screencapture.


Files

queuelimitpfsense.mp4 (563 KB) queuelimitpfsense.mp4 Vincent Jansen, 03/24/2021 04:38 PM
Actions #3

Updated by Vincent Jansen 7 months ago

Viktor Gurov wrote:

extra input validation:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/206

Hi Viktor,

Thanks for taking this up. For some reason I cannot access your pull-request.
Being a developer myself, are you sure that input validation is the way we should go about this?
Perhaps it would make more sense to remove the fields when a certain limiter is selected from the dropdown and with/without postback provide the optional fields.

I'm not a Pfsense developer and therefore I trust your justment. Just throwing it out there.

Actions #4

Updated by Jim Pingle 7 months ago

  • Subject changed from Setting Queue Limit causes error to Error when setting queue limit on CODELQ limiter
  • Status changed from Confirmed to Pull Request Review
  • Target version set to CE-Next
Actions #5

Updated by Jim Pingle 6 months ago

  • Status changed from Pull Request Review to Feedback
  • Target version changed from CE-Next to 2.6.0

PR was merged yesterday.

Actions #6

Updated by Jim Pingle 6 months ago

  • Plus Target Version set to 21.05
Actions #7

Updated by Jim Pingle 6 months ago

Already in 21.05 branch.

Actions #8

Updated by Jim Pingle 5 months ago

  • Target version changed from 2.6.0 to 2.5.2
Actions #9

Updated by Jim Pingle 5 months ago

  • Status changed from Feedback to Closed
Actions #10

Updated by Renato Botelho 4 months ago

  • Assignee set to Viktor Gurov
Actions

Also available in: Atom PDF