Project

General

Profile

Actions
Copy link

Regression #11981

closed
JP

Duplicating Outbound NAT rule does not carry over contents of the source rule

Regression #11981: Duplicating Outbound NAT rule does not carry over contents of the source rule

Added by Jim Pingle over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Rules / NAT
Target version:
2.5.2
Start date:
06/01/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

When using the copy button on an Outbound NAT rule on firewall_nat_out.php, the contents of the source rule are not copied to the edit screen for the new rule.

This appears to have been introduced in commit:d2eee7c82191c5870dbf90933c9050bf6dc37c07 which is in CE 2.5.2, CE 2.6.0, and Plus 21.09.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #2

  • Status changed from New to Pull Request Review

VG Updated by Viktor Gurov over 5 years ago Actions
Copy link
 #3

  • Status changed from Pull Request Review to Feedback

JP Updated by Jim Pingle about 5 years ago Actions
Copy link
 #4

Fix was not picked back to 2.5.2, but is now. Will be in future builds.

RB Updated by Renato Botelho about 5 years ago Actions
Copy link
 #5

  • Status changed from Feedback to In Progress

It actually broke duplication and is now acting like rule is being edited instead of creating a new one

RB Updated by Renato Botelho about 5 years ago Actions
Copy link
 #6

Renato Botelho wrote:

It actually broke duplication and is now acting like rule is being edited instead of creating a new one

I've found the issue happens because dup parameter is passed to firewall_nat_out_edit.php by GET and then form action preserves `?dup=0` appended to URL when it's called with save parameter

RB Updated by Renato Botelho about 5 years ago Actions
Copy link
 #7

  • Status changed from In Progress to Feedback

Fix pushed to 2.6.0 and 2.5.2

JP Updated by Jim Pingle about 5 years ago Actions
Copy link
 #8

  • Status changed from Feedback to Closed

Works with the latest RELENG_2_5_2 code in place.

JP Updated by Jim Pingle almost 5 years ago Actions
Copy link
 #9

  • Plus Target Version changed from 21.09 to 22.01
Actions
Copy link

Also available in: Atom