Regression #11981
closed
Duplicating Outbound NAT rule does not carry over contents of the source rule
0%
Description
When using the copy button on an Outbound NAT rule on firewall_nat_out.php, the contents of the source rule are not copied to the edit screen for the new rule.
This appears to have been introduced in d2eee7c82191c5870dbf90933c9050bf6dc37c07 which is in CE 2.5.2, CE 2.6.0, and Plus 21.09.
Updated by Viktor Gurov almost 3 years ago
Updated by Jim Pingle almost 3 years ago
- Status changed from New to Pull Request Review
Updated by Viktor Gurov almost 3 years ago
- Status changed from Pull Request Review to Feedback
Updated by Jim Pingle almost 3 years ago
Fix was not picked back to 2.5.2, but is now. Will be in future builds.
Updated by Renato Botelho almost 3 years ago
- Status changed from Feedback to In Progress
It actually broke duplication and is now acting like rule is being edited instead of creating a new one
Updated by Renato Botelho almost 3 years ago
Renato Botelho wrote:
It actually broke duplication and is now acting like rule is being edited instead of creating a new one
I've found the issue happens because dup parameter is passed to firewall_nat_out_edit.php by GET and then form action preserves `?dup=0` appended to URL when it's called with save parameter
Updated by Renato Botelho almost 3 years ago
- Status changed from In Progress to Feedback
Fix pushed to 2.6.0 and 2.5.2
Updated by Jim Pingle almost 3 years ago
- Status changed from Feedback to Closed
Works with the latest RELENG_2_5_2 code in place.
Updated by Jim Pingle over 2 years ago
- Plus Target Version changed from 21.09 to 22.01