Regression #12172: OpenVPN Wizard configuration missing recently added default values - pfSense - pfSense bugtracker

Actions

Copy link

Regression #12172

closed

OpenVPN Wizard configuration missing recently added default values

Added by Marcos M over 2 years ago. Updated over 2 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Viktor Gurov

Category:

OpenVPN

Target version:

2.6.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

22.01

Release Notes:

Default

Affected Version:

2.6.0

Affected Architecture:

Description

After generating an RA OpenVPN Server configuration through the wizard, config.xml contains the following:

<tls>Some_Key_A</tls>
<ncp_enable>on</ncp_enable>

After clicking edit then save on that wizard-generated server config, config.xml contains the following:

<tls>Some_Key_B</tls>
<ncp_enable>disabled</ncp_enable>
<exit_notify>none</exit_notify>
<inactive_seconds>0</inactive_seconds>

There may be other inconsistencies as well.

Actions

Copy link

Updated by Marcos M over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Viktor Gurov over 2 years ago

fix for ncp_enable value:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/305

but I cannot reproduce the incorrect exit_notify and inactive_seconds values

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Status changed from New to Pull Request Review
Target version set to 2.6.0
Plus Target Version set to 21.09

Actions

Copy link

Updated by Marcos M over 2 years ago

Note, the decoded TLS key is the same, only the xml contains different encoded text.

I can reproduce the issue described on the report when testing on:
21.05-RELEASE (amd64)
built on Tue Jun 01 16:52:56 EDT 2021

However, I get different results when testing the same steps on:
21.09-DEVELOPMENT (amd64)
built on Sun Aug 08 01:12:39 EDT 2021

Go to OpenVPN Wizard
Default selection; Click Next
Enter descriptive name; click Add new CA
Enter descriptive name; click Create new Certificate
Enter tunnel network; click Next
Click Next
Click Finish

Resulting config.xml is correct. After repeating steps (reusing created CA and cert from previous steps), latest dev version did not increment the local port automatically.

Actions

Copy link

Updated by Viktor Gurov over 2 years ago

Marcos Mendoza wrote in #note-4:

Resulting config.xml is correct. After repeating steps (reusing created CA and cert from previous steps), latest dev version did not increment the local port automatically.

The "Tunnel Network" value should also be cleared to avoid creating two instances with the same "Tunnel Network" value.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/332

Actions

Copy link

Updated by Viktor Gurov over 2 years ago

Status changed from Pull Request Review to Feedback
% Done changed from 0 to 100

Applied in changeset 883ea6ab4221caef114de98b3b63a5fbd8980fe9.

Actions

Copy link

Updated by Viktor Gurov over 2 years ago

Assignee set to Viktor Gurov

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Subject changed from OpenVPN Wizard generates incorrect configuration to OpenVPN Wizard configuration missing some recently added default values

Updating subject for release notes.

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Subject changed from OpenVPN Wizard configuration missing some recently added default values to OpenVPN Wizard configuration missing recently added default values

Actions

Copy link

#10