Project

General

Profile

Actions

Regression #12172

closed

OpenVPN Wizard configuration missing recently added default values

Added by Marcos Mendoza about 2 months ago. Updated 28 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OpenVPN
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.09
Release Notes:
Default
Affected Version:
2.6.0
Affected Architecture:

Description

After generating an RA OpenVPN Server configuration through the wizard, config.xml contains the following:

<tls>Some_Key_A</tls>
<ncp_enable>on</ncp_enable>

After clicking edit then save on that wizard-generated server config, config.xml contains the following:

<tls>Some_Key_B</tls>
<ncp_enable>disabled</ncp_enable>
<exit_notify>none</exit_notify>
<inactive_seconds>0</inactive_seconds>

There may be other inconsistencies as well.

Actions #1

Updated by Marcos Mendoza about 2 months ago

  • Description updated (diff)
Actions #2

Updated by Viktor Gurov about 2 months ago

fix for ncp_enable value:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/305

but I cannot reproduce the incorrect exit_notify and inactive_seconds values

Actions #3

Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.6.0
  • Plus Target Version set to 21.09
Actions #4

Updated by Marcos Mendoza about 2 months ago

Note, the decoded TLS key is the same, only the xml contains different encoded text.

I can reproduce the issue described on the report when testing on:
21.05-RELEASE (amd64)
built on Tue Jun 01 16:52:56 EDT 2021

However, I get different results when testing the same steps on:
21.09-DEVELOPMENT (amd64)
built on Sun Aug 08 01:12:39 EDT 2021

  1. Go to OpenVPN Wizard
  2. Default selection; Click Next
  3. Enter descriptive name; click Add new CA
  4. Enter descriptive name; click Create new Certificate
  5. Enter tunnel network; click Next
  6. Click Next
  7. Click Finish

Resulting config.xml is correct. After repeating steps (reusing created CA and cert from previous steps), latest dev version did not increment the local port automatically.

Actions #5

Updated by Viktor Gurov about 2 months ago

Marcos Mendoza wrote in #note-4:

Resulting config.xml is correct. After repeating steps (reusing created CA and cert from previous steps), latest dev version did not increment the local port automatically.

The "Tunnel Network" value should also be cleared to avoid creating two instances with the same "Tunnel Network" value.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/332

Actions #6

Updated by Viktor Gurov about 2 months ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions #7

Updated by Viktor Gurov about 2 months ago

  • Assignee set to Viktor Gurov
Actions #8

Updated by Jim Pingle 30 days ago

  • Subject changed from OpenVPN Wizard generates incorrect configuration to OpenVPN Wizard configuration missing some recently added default values

Updating subject for release notes.

Actions #9

Updated by Jim Pingle 30 days ago

  • Subject changed from OpenVPN Wizard configuration missing some recently added default values to OpenVPN Wizard configuration missing recently added default values
Actions #10

Updated by Jim Pingle 30 days ago

  • Tracker changed from Bug to Regression
  • Affected Version set to 2.6.0
Actions #11

Updated by Marcos Mendoza 28 days ago

  • Status changed from Feedback to Resolved

Looks good now.

Actions

Also available in: Atom PDF