pfSense

• When time based backups are selected, and no minutes value provided, a random value is generated and presented to the user
• The time based cron job is now created automatically using install_cron_job()
• Backups are now written to a file in /cf/conf/acb and uploaded to the server via the cron job /usr/local/sbin/acbupload.php
• Backups triggered by pfBlockerNG, Snort & minicron are not uploaded automatically

Seeing a set of PHP error from these changes:

[11-Aug-2021 10:45:00 America/New_York] PHP Warning:  Use of undefined constant lockfile - assumed 'lockfile' (this will throw an Error in a future version of PHP) in /usr/local/sbin/acbupload.php on line 35
[11-Aug-2021 10:45:00 America/New_York] PHP Warning:  filemtime(): stat failed for lockfile in /usr/local/sbin/acbupload.php on line 35
[11-Aug-2021 10:46:00 America/New_York] PHP Warning:  unlink(/tmp/acb.lock): No such file or directory in /usr/local/sbin/acbupload.php on line 66

Looks like that line source:src/usr/local/sbin/acbupload.php#L35 is missing a $ on the variable name:

Right now it is:

    if (time()-filemtime(lockfile) > (60 * 60)) {

Should be:

    if (time()-filemtime($lockfile) > (60 * 60)) {

Lockfile typo fixed.

This looks good now.

Files are queued as expected and uploaded when the cronjob fires.
The cronjob is created correctly on new installs when ACB is enabled.

The only thing that could be improved is that if access to acb is disabled for any reason the upload script still reports success:

Aug 18 12:34:43     php-fpm     41255     /services_acb_backup.php: Configuration Change: admin@172.21.16.5 (Local Database): Test10
Aug 18 12:34:43     php-fpm     41255     /services_acb_backup.php: Beginning configuration backup to https://acb.netgate.com/save
Aug 18 12:35:30     php     36064     /usr/local/sbin/acbupload.php: End of configuration backup to (success). 

Tested:

21.09-DEVELOPMENT (amd64)
built on Wed Aug 18 01:12:01 EDT 2021
FreeBSD 12.2-STABLE

2.6.0-DEVELOPMENT (amd64)
built on Wed Aug 18 01:08:59 EDT 2021
FreeBSD 12.2-STABLE