Project

General

Profile

Actions
Copy link

Bug #12264

closed

Stray <table> line in squid_monitor.php

Added by Matthew Fearnley over 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Viktor Gurov
Category:
Squid
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Affected Version:
2.5.2
Affected Plus Version:
Affected Architecture:

Description

There's a stray <table> opening element in the C-ICAP Virus Table section of /usr/local/www/squid_monitor.php

<table class="table table-hover table-condensed">
<table width="100%" border="0" cellpadding="0" cellspacing="0"> <-----------

See https://github.com/pfsense/FreeBSD-ports/blob/RELENG_2_5_2/www/pfSense-pkg-squid/files/usr/local/www/squid_monitor.php#L171

It looks like the first line was added in https://github.com/pfsense/FreeBSD-ports/commit/f05da7d03bbb62eb51c54f8923516235becd7a4e#diff-0dcff6e573ed851113faa438ad98008785e68ade0e6ec7248578696afdbf7feaR177, and the second one should have been deleted but was mistakenly left in.

I've attached a simple patch that removes the line.

Files

squid_monitor.patch (398 Bytes) squid_monitor.patch Matthew Fearnley, 08/16/2021 07:33 AM
Actions
Copy link
 #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
Actions
Copy link
 #3

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Pull Request Review to Feedback

Merged

Actions
Copy link
 #4

Updated by Danilo Zrenjanin about 2 years ago

  • Status changed from Feedback to Resolved

That line doesn't exist in the current Squid release squid_monitor.php.

I am marking this ticket resolved.

Actions
Copy link

Also available in: Atom PDF