Project

General

Profile

Actions

Bug #12757

open

Clean up /etc/inc/filter.inc use of pfctl -F

Added by Mark Francis 5 months ago. Updated about 13 hours ago.

Status:
Pull Request Review
Priority:
Very Low
Assignee:
-
Category:
Diagnostics
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.11
Release Notes:
Default
Affected Version:
Affected Architecture:
All

Description

Two recommended clean up actions:
1) filter_flush_state_table() in /etc/inc/filter.inc calls 'pfctl -F state' which is a typo for 'pfctl -F states' that just happens to work ... on the man page for [pfctl](https://www.freebsd.org/cgi/man.cgi?query=pfctl):

-F    nat       Flush the NAT rules.
-F queue Flush the queue rules.
-F rules Flush the filter rules.
-F states Flush the state table (NAT and filter).
-F Sources Flush the source tracking table.
-F info Flush the filter information (statistics that are
not bound to rules).
-F Tables Flush the tables.
-F osfp Flush the passive operating system fingerprints.
-F all Flush all of the above.

and the docs match the code [pfctl.c](https://github.com/freebsd/freebsd-src/blob/main/sbin/pfctl/pfctl.c)

2) Remove unused filter_flush_nat_table() function in filter.inc

Actions #1

Updated by Jim Pingle 5 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05
Actions #2

Updated by Jim Pingle about 1 month ago

  • Plus Target Version changed from 22.05 to 22.09
Actions #3

Updated by Jim Pingle about 13 hours ago

  • Plus Target Version changed from 22.09 to 22.11
Actions

Also available in: Atom PDF