Project

General

Profile

Actions
Copy link

Bug #12757

closed

Clean up use of ``pfctl -F`` in ``/etc/inc/filter.inc``

Added by Mark Francis about 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Jim Pingle
Category:
Diagnostics
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:
All

Description

Two recommended clean up actions:
1) filter_flush_state_table() in /etc/inc/filter.inc calls 'pfctl -F state' which is a typo for 'pfctl -F states' that just happens to work ... on the man page for [pfctl](https://www.freebsd.org/cgi/man.cgi?query=pfctl):

-F    nat       Flush the NAT rules.
         -F    queue       Flush the queue rules.
         -F    rules       Flush the filter rules.
         -F    states       Flush the state table (NAT and filter).
         -F    Sources       Flush the source tracking table.
         -F    info       Flush the filter information    (statistics that are
               not bound to    rules).
         -F    Tables       Flush the tables.
         -F    osfp       Flush the passive operating system fingerprints.
         -F    all       Flush all of    the above.

and the docs match the code [pfctl.c](https://github.com/freebsd/freebsd-src/blob/main/sbin/pfctl/pfctl.c)

2) Remove unused filter_flush_nat_table() function in filter.inc

Actions
Copy link
 #1

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05
Actions
Copy link
 #2

Updated by Jim Pingle almost 2 years ago

  • Plus Target Version changed from 22.05 to 22.09
Actions
Copy link
 #3

Updated by Jim Pingle almost 2 years ago

  • Plus Target Version changed from 22.09 to 22.11
Actions
Copy link
 #4

Updated by Jim Pingle over 1 year ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #5

Updated by Jim Pingle over 1 year ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Jim Pingle
  • % Done changed from 0 to 100

Changes made manually since the PR had conflicts and it was a small diff.

Actions
Copy link
 #6

Updated by Jim Pingle over 1 year ago

  • Subject changed from Clean up /etc/inc/filter.inc use of pfctl -F to Clean up use of ``pfctl -F`` in ``/etc/inc/filter.inc``
  • Release Notes changed from Default to Force Exclusion
Actions
Copy link
 #7

Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to Resolved

The code in question is gone.

Actions
Copy link

Also available in: Atom PDF