Project

General

Profile

Actions
Copy link

Bug #13071

closed

Delete function for IPsec SAD entries on ``status_ipsec_sad.php`` does not work

Added by Jim Pingle about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
IPsec
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

The delete function for IPsec SAD entries on status_ipsec_sad.php is not working due to a misplaced usepost attribute. It should be on the <a> tag. It also gathers the SAD info before performing the delete so the delete can never be reflected in the output until the page is refreshed. Fix the order while there.

There is also some debate about whether or not we need the delete function here any more. It's been broken for a while and went unnoticed, so it may be OK to remove as well.

Actions
Copy link
 #1

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #2

Updated by Jim Pingle about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Danilo Zrenjanin about 2 years ago

Tested the patch against the version below:

2.7.0-DEVELOPMENT (amd64)
built on Wed Apr 20 06:16:41 UTC 2022
FreeBSD 12.3-STABLE

The delete icon does remove the SAD entries under status_ipsec_sad.php.

Actions
Copy link
 #4

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #5

Updated by Jim Pingle about 2 years ago

  • Subject changed from Delete function for IPsec SAD entries on ``status_ipsec_sad.php`` is not working to Delete function for IPsec SAD entries on ``status_ipsec_sad.php`` does not work

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF