Regression #13111: when saving NAT rule using a port alias, strstr() expects at least 2 parameters, 1 given in /usr/local/pfSense/include/www/firewall_nat.inc error - pfSense - pfSense bugtracker

Actions

Copy link

Regression #13111

closed

when saving NAT rule using a port alias, strstr() expects at least 2 parameters, 1 given in /usr/local/pfSense/include/www/firewall_nat.inc error

Added by → luckman212 over 3 years ago. Updated over 3 years ago.

Status:

Duplicate

Priority:

Normal

Assignee:

Category:

PHP Interpreter

Target version:

Start date:

Due date:

% Done:

Estimated time:

Plus Target Version:

Release Notes:

Force Exclusion

Affected Version:

Affected Architecture:

Description

sorry for the terse bugreport, but I am onsite at a client at 10:30pm and desperately trying to get this HA pair of Netgates up and running. I had to roll back from 22.05 snaps to 22.01 and of course due to the config version bump I am having to redo the configs so I am short on time.

just wanted to log this one though: on 22.05, trying to save a NAT rule that contains a port alias results in a PHP crash

strstr() expects at least 2 parameters, 1 given in /usr/local/pfSense/include/www/firewall_nat.inc

I tried multiple times, I can post more detail tomorrow if needed

Actions

Copy link

Updated by → luckman212 over 3 years ago

Crash report begins.  Anonymous machine information:

amd64
12.3-STABLE
FreeBSD 12.3-STABLE plus-devel-12-n202664-041fc0bc0fd pfSense

Crash report details:

PHP Errors:
[30-Apr-2022 23:45:42 America/New_York] PHP Warning:  strstr() expects at least 2 parameters, 1 given in /usr/local/pfSense/include/www/firewall_nat.inc on line 520
[30-Apr-2022 23:45:42 America/New_York] PHP Warning:  strstr() expects at least 2 parameters, 1 given in /usr/local/pfSense/include/www/firewall_nat.inc on line 521

No FreeBSD crash data found.

Actions

Copy link

Updated by → luckman212 over 3 years ago

actually it looks like @vktg already fixed this in this commit: https://github.com/pfsense/pfsense/commit/1aa4beab67da79d69df094771a4317279318227d

I added that to system patches and now am able to save the NAT rule successfully. Strangely, I saw that commit before and tried to patch it while I was still onsite wrestling with that HA pair, and it didn't work. But maybe I needed to restart PHP-FPM and the webConfigurator first.

Actions

Copy link