Regression #13117
closed
pfBlockerNG DNSBL unbound python mode prevents deletion of OpenVPN server and client configurations
100%
Description
Issue exists on 22.05.a.20220429.1807.
Issue not present on 22.05.a.20220426.1313.
If DNS Resolver has Enable Python Module with pfb_unbound set, OpenVPN server and client configurations cannot be edited or deleted. Cloning and editing before saving does works, but the new entry cannot be edited/deleted after saving. I tried keeping the python module option enabled while toggling other DNSBL / DNS Resolver options, but it seems only that setting triggers the issue.
Files
Related issues
Updated by Marcos M over 2 years ago
- Category changed from DNS Resolver to Unknown
- Priority changed from High to Normal
It seems the issue described initially is a symptom of a race condition with writing the configuration. Still investigating.
Edit: It seems that was a separate issue preventing the edits. Deleting is still an issue:
Steps to reproduce:- Fresh install of
22.05.a.20220429.1807 - Setup OpenVPN
- Create default ca
- Create a disabled OpenVPN client config with default settings pointed to bogus server
- Setup pfBlockerNG
- Install pfBlockerNG-devel
3.1.0_4 - Go through pfB wizard with all default options
- Enable unbound python mode in pfB DNSBL
- Force a reload on pfB for "All"
- Install pfBlockerNG-devel
- Try to delete the OpenVPN client entry
- It does not delete; it comes back after page reload and no changes are written to config.xml
- Delete change is logged to system log and backup revision
- Edit the description; it works
- Uncheck
Python Modulein DNS Resolver- Deleting the OpenVPN entry now works
Updated by Marcos M over 2 years ago
- Subject changed from pfBlockerNG unbound python module prevents modification of existing OpenVPN server and client configurations to pfBlockerNG DNSBL unbound python mode prevents deletion of OpenVPN server and client configurations
- Tested with DNSBL python mode enabled, but using a different python script (attached).
- Tested with DNSBL python mode disabled, but enabling and setting the pfb_unbound.py script in DNS Resolver.
Updated by Marcos M over 2 years ago
- File netflix-no-aaaa.py netflix-no-aaaa.py added
Updated by Viktor Gurov over 2 years ago
- Related to Bug #12991: DNS Resolver ACLs are not updated when OpenVPN networks change added
Updated by Viktor Gurov over 2 years ago
- Tracker changed from Bug to Regression
- Category changed from Unknown to OpenVPN
- Assignee set to Viktor Gurov
- Target version set to 2.7.0
- Plus Target Version set to 22.05
Updated by Viktor Gurov over 2 years ago
- Release Notes changed from Default to Force Exclusion
Updated by Steve Wheeler over 2 years ago
- Status changed from New to Pull Request Review
That patch fixes it in my test VM.
Tested: 22.05.a.20220504.0600 with pfBlocker 3.1.0_4
Updated by Viktor Gurov over 2 years ago
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset 2d033c13777e13497e0852d4cb8da39c79978798.