Project

General

Profile

Actions

Regression #13122

closed

PHP error from Captive Portal status on current development snapshots

Added by Jim Pingle almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Captive Portal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Affected Version:
2.7.0
Affected Architecture:

Description

Loading the Captive Portal status page on a current development snapshot while a user is logged into the portal results in a PHP error:

[03-May-2022 11:50:10 America/Indiana/Indianapolis] PHP Fatal error:  Uncaught Error: Call to undefined function pfSense_pf_get_eth_rule_counters() in /etc/inc/captiveportal.inc:1725
Stack trace:
#0 /usr/local/www/status_captiveportal.php(108): getVolume('10.23.0.13')
#1 /usr/local/www/status_captiveportal.php(269): print_details(Array)
#2 {main}
  thrown in /etc/inc/captiveportal.inc on line 1725

The resulting page output is truncated as a result.

The function call is using the wrong name. pfSense_pf_get_eth_rule_counters() should be pfSense_pf_cp_get_eth_rule_counters()

To me, I have a fix.

Actions #1

Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Danilo Zrenjanin almost 2 years ago

  • Status changed from Feedback to Resolved

Tested:

2.7.0-DEVELOPMENT (amd64)
built on Wed May 11 06:37:51 UTC 2022
FreeBSD 12.3-STABLE

There were no PHP errors when visiting Status/Captive Portal/test with a user connected.

Actions

Also available in: Atom PDF