Project

General

Profile

Actions

Bug #13228

closed

Recovering interface gateway may not be added back into gateway groups and rules when expected

Added by Jim Pingle over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Gateways
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

When an interface/gateway recovers and rc.newwanip runs, the gateway may not end up in the ruleset in groups or rules as expected. This doesn't affect every setup or event, but it's not clear why it isn't consistent. Users report that manually running a filter reload after the system settles, without changing any settings, returns the groups and rules to the expected state.

The following diff triggers a filter reload at the end of rc.newwanip unconditionally which appears to help based on user reports:

diff --git a/src/etc/rc.newwanip b/src/etc/rc.newwanip
index 34aa4c602d..ae2c68fa38 100755
--- a/src/etc/rc.newwanip
+++ b/src/etc/rc.newwanip
@@ -279,9 +279,7 @@ if (!is_ipaddr($oldip) || ($curwanip != $oldip) || file_exists("{$g['tmp_path']}
        if (empty($config['interfaces'][$interface]['ipaddrv6'])) {
                unlink_if_exists("{$g['tmp_path']}/{$interface}_upstart6");
        }
-} else {
-       /* signal filter reload */
-       filter_configure();
 }

+filter_configure();
 ?>

Without knowing more about why it helps I'm hesitant to commit that as-is at this point, but we can investigate and consider it for the next release.

Actions #2

Updated by Jim Pingle over 2 years ago

  • Plus Target Version changed from 22.09 to 22.11
Actions #3

Updated by Lee Brown over 2 years ago

I have this issue. Adding the filter_configure(); to the end, (while not removing the else block) does resolve this for me. The filter reload is called properly and new traffic is routed out the correct WAN2 gateway.

Actions #4

Updated by Jim Pingle over 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions #6

Updated by Jim Pingle about 2 years ago

  • Category changed from Interfaces to Gateways
Actions #7

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved

Seems to be doing OK here for now, and was previously found to help before committing.

If there is a regression discovered later, we can handle it separately.

Actions

Also available in: Atom PDF