Project

General

Profile

Actions

Bug #13228

open

Recovering interface gateway may not be added back into gateway groups and rules when expected

Added by Jim Pingle about 1 month ago. Updated 29 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
Interfaces
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.09
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

When an interface/gateway recovers and rc.newwanip runs, the gateway may not end up in the ruleset in groups or rules as expected. This doesn't affect every setup or event, but it's not clear why it isn't consistent. Users report that manually running a filter reload after the system settles, without changing any settings, returns the groups and rules to the expected state.

The following diff triggers a filter reload at the end of rc.newwanip unconditionally which appears to help based on user reports:

diff --git a/src/etc/rc.newwanip b/src/etc/rc.newwanip
index 34aa4c602d..ae2c68fa38 100755
--- a/src/etc/rc.newwanip
+++ b/src/etc/rc.newwanip
@@ -279,9 +279,7 @@ if (!is_ipaddr($oldip) || ($curwanip != $oldip) || file_exists("{$g['tmp_path']}
        if (empty($config['interfaces'][$interface]['ipaddrv6'])) {
                unlink_if_exists("{$g['tmp_path']}/{$interface}_upstart6");
        }
-} else {
-       /* signal filter reload */
-       filter_configure();
 }

+filter_configure();
 ?>

Without knowing more about why it helps I'm hesitant to commit that as-is at this point, but we can investigate and consider it for the next release.

Actions

Also available in: Atom PDF