Project

General

Profile

Actions

Bug #13467

closed

ACME: "Unable to find domain name" error when updating Namesilo

Added by Bryan Guscott 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ACME
Target version:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
Affected Plus Version:
Affected Architecture:

Description

Issue is documented here:
https://github.com/acmesh-official/acme.sh/issues/4268

Issue text, copied here:

Getting an error trying to issue DNS certs from NameSilo. Error says it can't find the domain.

That's because Line 113 of dns_namesilo.sh:
if _contains "$response" "<domain>$host"; then

is looking for the string <domain>, but the NameSilo API is now returning
<domain expires="2023-02-26">test.com</domain>
The addition of the "expires" property is breaking the string match, so it fails to find the domain in the XML and aborts.

The acme package version 0.7.1_1 needs to be updated with the fix from:
https://github.com/acmesh-official/acme.sh/commit/3dde83d8a0b911bf7740fa86db2997aa66cd9522

Actions #1

Updated by Jim Pingle 3 months ago

  • Project changed from pfSense to pfSense Packages
  • Subject changed from acme package dns namesilo bug - unable to find domain name error to ACME: "Unable to find domain name" error when updating Namesilo
  • Category changed from Package System to ACME
  • Release Notes deleted (Default)

That fix will be picked up naturally the next time we update the acme.sh code from upstream.

Actions #2

Updated by Jim Pingle about 2 months ago

  • Assignee set to Jim Pingle
Actions #3

Updated by Jim Pingle about 2 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Addressed in ACME pkg v0.7.3

Actions #4

Updated by Danilo Zrenjanin about 1 month ago

  • Status changed from Feedback to Resolved

Tested against ACME pkg v0.7.3.

It contains the patch.

cat -n /usr/local/pkg/acme/dnsapi/dns_namesilo.sh | grep 113

113        if _contains "$response" ">$host</domain>"; then

I am marking this ticket as resolved.

Actions

Also available in: Atom PDF