Project

General

Profile

Actions

Todo #13644

open

Enable ALTQ support in cxgbe(4)

Added by Steve Wheeler over 1 year ago. Updated over 1 year ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
Traffic Shaper (ALTQ)
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Plus-Next
Release Notes:
Default

Description

The cxgbe(4) driver is shown in documentation as supporting ALTQ but the code there appears to have had that removed as far back as 2012.

The pfSense input error checking shows it as supported and allows selecting cxgbe interface types for traffic shaping. The results in an unloadable ruleset.

There are a number of previous tickets relating to this where support for cxgbe interface types was added to pfSense but it appears it could never have worked.

ALTQ support should be added ideally. If it cannot be the cxgbe NICs should be removed from the supported interface list to prevent creating a bad ruleset.

Actions #1

Updated by Kristof Provost over 1 year ago

Unfortunately it's not straightforward to re-enable ALTQ support in the cxgbe(4) driver. It has been substantially altered since ALTQ support was removed, and the new structure does not lend itself to supporting ALTQ.

I've updated the relevant FreeBSD man pages, and removed it from the list of supported interfaces: https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/926

Actions #2

Updated by Victor Coss over 1 year ago

Kristof Provost wrote in #note-1:

Unfortunately it's not straightforward to re-enable ALTQ support in the cxgbe(4) driver. It has been substantially altered since ALTQ support was removed, and the new structure does not lend itself to supporting ALTQ.

I've updated the relevant FreeBSD man pages, and removed it from the list of supported interfaces: https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/926

Would cxl be included in that? Just curious because in the commit on GitHub you didn't remove it, yet on the FreeBSD manpage for CXGBE it's listed as one of the port names for the T5 based ASIC.

See: https://www.freebsd.org/cgi/man.cgi?query=cxgbe&sektion=4

I ask because I was planning on getting a Chelsio CH-T540-SO-CR which uses the T5 based ASIC and would be cxl.

Actions #3

Updated by Steve Wheeler over 1 year ago

  • Status changed from New to In Progress

Yes, cxl should also be removed. It doesn't support altq either, that's what I was testing with. Expect an additional patch there shortly.

Actions

Also available in: Atom PDF