Project

General

Profile

Actions

Bug #13667

closed

QuickAssist hardware not recognized

Added by johnny stecchino about 2 years ago. Updated about 2 years ago.

Status:
Duplicate
Priority:
Normal
Category:
Cryptographic Modules
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Release Notes:
Default
Affected Plus Version:
23.01
Affected Architecture:
amd64

Description

see https://forum.netgate.com/topic/175893/quickassist-doesn-t-seem-to-be-working

This is part of a larger issue as pciconf -l output format has changed between freebsd 12 and 14.

freebsd 12 pciconf -l was:

qat0@pci0:0:11:0: class=0x0b4000 card=0x00008086 chip=0x1f188086 rev=0x02 hdr=0x00

freebsd 14 pciconf -l is now :

qat0@pci0:8:0:0: class=0x0b4000 rev=0x00 hdr=0x00 vendor=0x8086 device=0x0435 subvendor=0x8086 subdevice=0x0000

Any function relying on info from pciconf may be affected.

in this particular case with quickassist, the function get_cpu_crypto_support() in /usr/local/www/includes/functions.inc.php needs to be updated.

here is the change that works for me::

/usr/local/www/includes: diff functions.inc.php.old functions.inc.php
369c369
<         exec("/usr/sbin/pciconf -l | /usr/bin/awk '{ printf \"%s\\n\", $4 }' | /usr/bin/cut -f2 -d=", $pciids);
---
>         exec("/usr/sbin/pciconf -l | /usr/bin/awk '{ printf \"%s%s\\n\", $6, substr($5,10,4) }' | /usr/bin/cut -f2 -d=", $pciids);

I haven't checked the rest of the file for anything else relying on pciconf


Related issues

Is duplicate of Regression #13491: Crypto devices are not detected on current snapshots because the format of pciconf has changedResolvedKristof Provost

Actions
Actions #1

Updated by Kristof Provost about 2 years ago

  • Status changed from New to Pull Request Review
  • Assignee set to Kristof Provost
Actions #2

Updated by Kristof Provost about 2 years ago

I've checked, and the only other use of pciconf in the GUI is intended for human consumption (on the status.php page), so we don't need worry about the changed format there.

Actions #3

Updated by Jim Pingle about 2 years ago

  • Status changed from Pull Request Review to Duplicate

Duplicate of #13491

Actions #4

Updated by Jim Pingle about 2 years ago

  • Is duplicate of Regression #13491: Crypto devices are not detected on current snapshots because the format of pciconf has changed added
Actions

Also available in: Atom PDF