Project

General

Profile

Actions
Copy link

Bug #13755

closed

Multiple incorrect configuration paths in recent UPnP code changes

Added by Marcos M over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
UPnP/NAT-PMP
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

The automatic rule pass multicast traffic to miniupnpd is never created.

Actions
Copy link
 #1

Updated by Marcos M over 1 year ago

The miniupnp auto rule has been broken since the code was committed due to the invalid config path access, and due to the protocol being tcp instead of udp. The default allow rule already passes the traffic, hence simply remove the broken code.

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/979

Actions
Copy link
 #2

Updated by Marcos M over 1 year ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #3

Updated by Jim Pingle over 1 year ago

  • Assignee changed from Marcos M to Jim Pingle

There is at least one other place using the same incorrect test for upnp being enabled, and I'd prefer a slightly different approach to fixing the rules than the one in the PR. I'll take care of these.

Actions
Copy link
 #4

Updated by Jim Pingle over 1 year ago

  • Subject changed from Automatic rules for miniupnp are not created. to Multiple incorrect configuration paths in recent UPnP code changes

I spotted another incorrect configuration path usage in there as well as I was testing. Commit coming shortly.

Actions
Copy link
 #5

Updated by Jim Pingle over 1 year ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to Resolved

All working well on current snapshots:

  • No trace of UPnP anchors/rules in ruleset when UPnP is disabled
  • Enabling UPnP starts the service and reloads the ruleset
  • UPnP anchors/rules are present after enabling UPnP
  • When disabling UPnP, the service is stopped and the rules are reloaded, removing all traces again
  • At boot, the message saying UPnP is starting only prints when UPnP is enabled.
Actions
Copy link

Also available in: Atom PDF