Actions
Bug #13756
closedRules for authenticated Captive Portal users are not removed when a zone is disabled
Start date:
Due date:
% Done:
100%
Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
2.7.0
Affected Architecture:
All
Description
Users that have been authenticated by the captive portal are added as ether pass rules to the 'cpzoneid_X_auth' anchor.
If the captive portal instance is disabled or removed those rules should also be removed but they are not.
That appears to be because the database containing the user list is unlinked before the rule removal function is run:
etc/inc/captiveportal.inc#L407
/* remove old information */ unlink_if_exists("{$g['vardb_path']}/captiveportal{$cpzone}.db"); unlink_if_exists("{$g['vardb_path']}/captiveportal_radius_{$cpzone}.db"); unlink_if_exists("{$g['vardb_path']}/captiveportal_{$cpzone}.rules"); /* Release allocated pipes for this zone */ $pipes_to_remove = captiveportal_free_dnrules(); captiveportal_delete_rules($pipes_to_remove);
Updated by Steve Wheeler about 2 years ago
Tested:
23.01-DEVELOPMENT (arm64) built on Wed Dec 14 06:05:19 UTC 2022 FreeBSD 14.0-CURRENT
Updated by Jim Pingle about 2 years ago
- Subject changed from Captive Portal authenticated user rules are not removed when it is disabled. to Rules for authenticated Captive Portal users are not removed when a zone is disabled
Updating subject for release notes.
Updated by Steve Wheeler about 2 years ago
- Status changed from New to Pull Request Review
Updated by Jim Pingle about 2 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Steve Wheeler
- % Done changed from 0 to 100
MR merged
Updated by Jim Pingle almost 2 years ago
- Status changed from Feedback to Resolved
Rules for logged-in users are removed when disabling a portal zone as expected now.
Updated by Jim Pingle over 1 year ago
- Affected Version changed from 2.6.0 to 2.7.0
Actions