Project

General

Profile

Actions

Bug #13946

closed

Polish translation contains an invalid ``sprintf()`` format in the text for ``firewall_nat_out_edit.php``

Added by Jim Pingle about 1 year ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Category:
Translations
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

A PHP error occurs when a user tries to open firewall_nat_out_edit.php when using the Polish translation:

[08-Feb-2023 12:43:24 Europe/Warsaw] PHP Fatal error:  Uncaught ValueError: Unknown format specifier "A" in /usr/local/www/classes/Form/Input.class.php:127
Stack trace:
#0 /usr/local/www/classes/Form/Input.class.php(127): sprintf('Po\xC5\x82\xC4\x85czenia pa...', '<b>', '</b>', '<br />', '<a href="firewa...', '</a>')
#1 /usr/local/www/firewall_nat_out_edit.php(193): Form_Input->setHelp('Connections mat...', '<b>', '</b>', '<br />', '<a href="firewa...', '</a>')
#2 {main}
  thrown in /usr/local/www/classes/Form/Input.class.php on line 127

This appears to be from a missing s in the translated string in source:src/usr/local/share/locale/pl/LC_MESSAGES/pfSense.po#L23498 :

#: src/usr/local/www/firewall_nat_out_edit.php:568
#, php-format
msgid "" 
"Connections matching this rule will be mapped to the specified " 
"%1$sAddress%2$s.%3$sThe %1$sAddress%2$s can be an Interface, a Host-type " 
"Alias, or a %4$sVirtual IP%5$s address." 
msgstr "" 
"Połączenia pasujące do tej reguły będą mapowane do określonego %1$s Addresu " 
"%2$s.%3$sTen%1$sAddres%2$s może być interfejsem, aliasem hosta lub, %4$ " 
"Adresem Wirtualnego adresu IP %5$s." 

Note that %4$ which looks like it should be %4$s.

It will need fixed in Zenata and then the .po/.mo need to be regenerated.

Actions #1

Updated by Jim Pingle 11 months ago

  • Plus Target Version set to 23.09
Actions #2

Updated by Jim Pingle 10 months ago

  • Assignee set to Christian McDonald
Actions #3

Updated by Christian McDonald 10 months ago

  • Status changed from New to Closed

Fixed

Actions #4

Updated by Christian McDonald 10 months ago

  • Status changed from Closed to Resolved
Actions

Also available in: Atom PDF