Project

General

Profile

Actions

Bug #13954

closed

Invalid custom DHCP option data can cause the DHCP daemon to fail

Added by Corey Cooper about 1 year ago. Updated about 1 year ago.

Status:
Duplicate
Priority:
Normal
Assignee:
-
Category:
DHCP (IPv4)
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.6.0
Affected Architecture:
i386

Description

It took a 24 hours and 30 configuration changes to be noticed, so I don't know exactly what I did (I'm a newb in pfSense, and trying to make something everyone says is easy, work). The symptoms were DHCP stopped working on my system and the DHCP System Log contained:

Feb 12 20:32:46 dhcpd 4463 /etc/dhcpd.conf line 62: semicolon expected.
Feb 12 20:32:46 dhcpd 4463 option custom-s_lan_4-0 4,
Feb 12 20:32:46 dhcpd 4463 ^
Feb 12 20:32:46 dhcpd 4463 Configuration file errors encountered -- exiting

after that it showed several lines of how to report bugs to isc.org, and then:

Feb 12 22:32:46 dhcpd 74267 exiting.

I reported it to https://forum.netgate.com/topic/177806/dhcpd-stopped-working-fixed-but-trying-to-figure-it-out where eventually I was told to report it as a bug.

My system is an older HP mini pc I rescued from the recycle at one of my jobs, it is an i5-6500 with 16GB ram and 256GB SSD and an onboard intel em driver Ethernet port. I bought and installed a 4 port bge driver BCM5719 chipset pcie card as well. I am using the em0 as WAN, bge0 as LAN, opt1 (LANGARAGE) bge0 as second LAN, and opt3 bge3 as WAN2.

When I discovered the problem I kept reverting to older and older backups until # 30 fixed the problem, # 29 has the problem. I have included both those backup files, as well as the diff file between them, and the dhcpd.conf files created by each of them, marked appropriately.

I hope I got all the information you need to figure it out. Being a Windows C++ programmer I know how hard it is to get full bug information, but being total newb in pfSense and FreeBSD I'm sure I've missed something, so feel free to email or call me if there is anything else I can do to help.

My business email is best to get me at , put pfSense somewhere in the subject, or my cell phone is 818-535-1979.

C.

Files

DHCP_Error.zip (21.6 KB) DHCP_Error.zip Corey Cooper, 02/14/2023 03:49 PM

Related issues

Is duplicate of Feature #13584: Input validation for numbered DHCP options in static mappingsResolvedChristian McDonald

Actions
Actions #1

Updated by Jim Pingle about 1 year ago

  • Subject changed from A configuration in WebConfigurator caused an invalid line in dhcpd.conf, which shuts down dhcp to Invalid custom DHCP option data can cause the DHCP daemon to fail
  • Status changed from New to Duplicate

I can't replicate this here on snapshots as it appears to be fixed by #13584.

Your error was caused because you entered an invalid combination of custom option data. The type is "signed integer 32" but the value is "4,294,966,272" -- Which is invalid because (a) integer values shouldn't have commas and (b) even without the commas it is out of range for 32-bit signed integers (-2147483648 to 2147483647).

If I attempt to input that value into a custom option either in the main DHCP options or under a static mapping on development snapshots, input validation rejects it.

#13584 was addressed after 2.6.0, which is why yours was able to fail.

Actions #2

Updated by Jim Pingle about 1 year ago

  • Is duplicate of Feature #13584: Input validation for numbered DHCP options in static mappings added
Actions

Also available in: Atom PDF