Bug #14041
closed
Post-install migration of existing settings throws a PHP error when the configuration contains the legacy layout of a single alias in a Pass List.
100%
Description
Some time back the Pass List logic in Suricata was changed to allow the addition of multiple custom IPs and/or aliases to a custom Pass List. This new logic changed the existing <address></address> XML field into an array with items. Multiple IPs or aliases are assigned as elements of this array. The settings migration code called during package installation tests for the older non-array layout and converts it to the new array-based layout. However, under PHP 8.1 the check throws a PHP error when it encounters a legacy non-array based layout. The offending code section uses a pair of is_array() calls with one of them testing for a multi-dimensional array.
Updated by Bill Meeks about 2 years ago
I will work on this and submit a pull request containing the fix.
Updated by Bill Meeks about 2 years ago
A pull request containing the fix for this issue has been submitted here: https://github.com/pfsense/FreeBSD-ports/pull/1241. When this request is merged, this issue can be marked "resolved".
Updated by Jim Pingle about 2 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
PR merged, thanks!