Project

General

Profile

Actions

Bug #14079

closed

Debug descriptions misleading

Added by Jon Brown over 2 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
System Patches
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Affected Version:
2.6.0
Affected Plus Version:
Affected Architecture:
All

Description

the purpose of the debug button is

Use the 'Debug' option for details on whether or not the package can apply or revert a given patch.

The text for the messages need to tidying up and I make notes for each below.

When i click on the debug button for a patch that is not applied I get the following message:
unapplied patch debug button message
  • Patch does not revert cleanly (detail) = I am not sure whether the logic is working correctly here or whether or not this message should be hidden because the message is incorrect.
When i click on the debug button for a patch that is applied I get the following message:
applied patch debug button message
  • Patch does not apply cleanly (detail) = The patch is already applied correctly, this message should be hidden because it has been applied cleanly so you only need to know if it will revert cleanly or not.

Files

unapplied.jpg (21.2 KB) unapplied.jpg unapplied patch debug button message Jon Brown, 03/06/2023 01:18 PM
applied.jpg (25.2 KB) applied.jpg applied patch debug button message Jon Brown, 03/06/2023 01:20 PM
Actions #1

Updated by Jim Pingle over 2 years ago

  • Status changed from New to Rejected

The current text is correct. There is no need to suppress anything, it's clearly explained in the result string.

Every result needs both types printed because some patches may actually apply AND revert depending upon their content. Hiding the results goes against the idea of "debugging" -- you need all the detail there.

Most people don't even need to click that button, they just need to check which buttons are available and click whichever one they need.

Actions

Also available in: Atom PDF