Project

General

Profile

Actions
Copy link

Regression #14336

closed

Firewall logs do not show the rule description

Added by Marcos M almost 1 year ago. Updated almost 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Jim Pingle
Category:
System Logs
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.05
Release Notes:
Force Exclusion
Affected Version:
2.7.0
Affected Architecture:

Description

Tested in 23.05.b.20230428.2019. It previously worked on 23.05.b.20230428.1452.

Firewall log entries under Status / System Logs / Firewall / Normal View no longer show the rule description - only the rule tracking ID is shown.

Actions
Copy link
 #1

Updated by Jim Pingle almost 1 year ago

  • Target version set to 2.7.0
  • Plus Target Version set to 22.05
Actions
Copy link
 #2

Updated by Marcos M almost 1 year ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Jim Pingle almost 1 year ago

  • Status changed from Confirmed to In Progress
  • Assignee set to Jim Pingle

The structure of the labels returned by pfSense_get_pf_rules() changed but it appears to be a simple change to fix.

Actions
Copy link
 #4

Updated by Jim Pingle almost 1 year ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Jim Pingle almost 1 year ago

  • Plus Target Version changed from 22.05 to 23.05
Actions
Copy link
 #6

Updated by Jim Pingle almost 1 year ago

  • Release Notes changed from Default to Force Exclusion
Actions
Copy link
 #7

Updated by Marcos M almost 1 year ago

  • Status changed from Feedback to Confirmed

I applied the patch and the rule column now shows:

id:1677444350 (1677444350)

The user description is still missing.

Actions
Copy link
 #8

Updated by Jim Pingle almost 1 year ago

Make sure you're on the latest snapshot, not just applying the patch. It's possible your module is out of date.

It works for me on 2.7.0.a.20230502.0600 and 23.05.b.20230502.0600 with the patch applied.

Actions
Copy link
 #9

Updated by Jim Pingle almost 1 year ago

Nevermind, I see it now. It worked in some cases but not all.

Actions
Copy link
 #10

Updated by Jim Pingle almost 1 year ago

  • Status changed from Confirmed to Feedback

Looks like the user label is in there first, not last, but my logs were so full of default deny blocks (one label, so always worked) that it was hard to spot.

Commit 9f3f2b6f485cb9309837ebcc33e982d965938d5b should fix it. If it doesn't, Then I have another idea, but it's more complicated so trying to avoid the extra complexity if possible.

Actions
Copy link
 #11

Updated by Marcos M almost 1 year ago

  • Status changed from Feedback to Resolved

Patches fixed the issue.

Actions
Copy link

Also available in: Atom PDF