Regression #14517
closed
Log rotation is not active if the configuration contains an empty ``<syslog>`` section or if that section is not present
100%
Description
Similar to how logging didn't work in #14283, if the <syslog> section of config.xml is missing or empty, the newsyslog configuration for log rotation does not end up in /var/etc/newsyslog.conf.d/pfSense.conf.
As with #14283 there is an invalid test at src/etc/inc/syslog.inc#L520 that doesn't setup the newsyslog configuration when that configuration section is empty.
Simple workaround is to set some value in the log settings ( Status > System Logs , Settings tab ) such as disabling rotation compression.
Checking the source I don't see any other places using that same test, this is the only one remaining.
Updated by Jim Pingle 11 months ago
- Status changed from New to Feedback
Applied in changeset 892de1ecdaa23b164f6b2a2251d7538eee2199ea.
Updated by Jim Pingle 11 months ago
- Subject changed from Log rotation is not active if the configuration contains an empty ``<syslogd>`` section or if that section is not present to Log rotation is not active if the configuration contains an empty ``<syslog>`` section or if that section is not present
- Description updated (diff)
Updated by Danilo Zrenjanin 10 months ago
- Status changed from Feedback to Resolved
Tested the patch against the:
23.05.1-RELEASE (amd64) built on Wed Jun 28 03:57:27 UTC 2023 FreeBSD 14.0-CURRENT
It fixes the absence of the newsyslog configuration in /var/etc/newsyslog.conf.d/pfSense.conf after importing the config with a missing or empty <syslog> section.
I am marking this ticket resolved.
Updated by Jim Pingle 10 months ago
- Target version changed from CE-Next to 2.8.0