Project

General

Profile

Actions
Copy link

Bug #14724

closed

Suricata package incorrectly accounts for 24-hour rollover when creating automated rules update cron task and a 12-hour update interval is selected

Added by Bill Meeks almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Suricata
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Affected Version:
All
Affected Plus Version:
23.05.1
Affected Architecture:
All

Description

The Suricata package GUI incorrectly adjusts the starting hour for the automated rules update cron task when the user selects a 12-hour update interval and chooses either midnight or 12:00 noon as one of the two start times. Instead of rolling over any hours value greater than 23 to 00, it instead writes a start time of 24 for the hours value in crontab.

This same bug was documented in the Snort package here: https://forum.netgate.com/topic/182480/snort-rule-update-settings-time-has-a-bug-with-the-cron-job. Because Suricata and Snort share much of the same PHP code, the bug is also present in Suricata. I will submit a fix for this.

Actions
Copy link
 #1

Updated by Bill Meeks almost 2 years ago

Pull Request 1289 (https://github.com/pfsense/FreeBSD-ports/pull/1289) has been submitted to correct this issue. This ticket can be marked "Resolved" when the pull request is merged.

Actions
Copy link
 #2

Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Resolved

PR merged, thanks!

Actions
Copy link

Also available in: Atom PDF