Project

General

Profile

Actions

Todo #14750

closed

Automatically configure PF states hash table size

Added by Marcos M 7 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Operating System
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default

Description

See net.pf.states_hashsize in pf(4):

Size of hash tables that store states. Should be power of 2. Default value is 131072.

States are locked per hashrow, so if there are a lot of them in the same row they contend on the same lock (and that’s also the lock needed when exporting state information to userspace). One or two states per row is ideal.

Actions #1

Updated by Marcos M 7 months ago

  • Status changed from New to Pull Request Review
Actions #2

Updated by Jim Pingle 7 months ago

  • Assignee set to Marcos M
  • Target version set to 2.8.0
  • Plus Target Version set to 23.09
Actions #3

Updated by Marcos M 7 months ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions #4

Updated by Jim Pingle 7 months ago

  • Subject changed from Automatically configure the state hash tables size to Automatically configure PF states hash table size

Updating subject for release notes.

The original description here doesn't match what was committed. The commit is for net.pf.states_hashsize but the original description has net.pf.source_nodes_hashsize. I went by what was committed since that seemed to be the intent.

Actions #5

Updated by Marcos M 7 months ago

  • Description updated (diff)

Indeed I meant net.pf.states_hashsize.

Actions #6

Updated by Jim Pingle 7 months ago

  • Status changed from Feedback to Resolved

Appears to be using the expected value based on the given calculation.

Actions #7

Updated by Jim Pingle 5 months ago

  • Target version changed from 2.8.0 to 2.7.1
Actions

Also available in: Atom PDF