Deleting a VIP leaves <vip/> in config.xml
Each deleted VIP leaves <vip/> in config.xml. For example after deleting 3 VIPs:
#2 Updated by Pierre POMES almost 10 years ago
Target has been changed to 3.0, however, on the NAT screen, the list of available addresses contains empty elements (see screenshot)
So maybe a new ticket could be created to fix code in /etc/inc/util.inc in the function used to build the addresses list ?
#3 Updated by Chris Buechler almost 10 years ago
The target was changed because this was caused by the new XML parser code that's been reverted, so this is no longer an issue. ("Affected version" isn't accurate in this case, maybe we need a "none" for unusual cases like this)
Pierre - I suspect you're seeing something different there, at least when I tested this after the XML parser was reverted, it no longer did this.
#4 Updated by Pierre POMES almost 10 years ago
Hum, I tried a 2009/12/01 snapshot (pfSense-Full-Update-2.0-ALPHA-ALPHA-20091201-1245.tgz), here are my results:
- I cleaned up all my <vip/> entries in config.xml, the "External address" field in NAT (port forward) is ok
- I defined a carp interface, and I deleted it. My config.xml does contain an empty "<vip/>"
- The "External address" field in NAT (port forward) shows an empty address "()" in the list.
I had a quick look in the code, a loop on $config['virtualip']['vip'] is done to fill up "option" HTML tags, and use $config['virtualip']['vip']['subnet'] without no check: so if config.xml contains an empty <vip/>, an empty "option" html tag will be generated.
(/usr/local/www/firewall_nat_edit.php, line 322)