Project

General

Profile

Actions

Feature #15233

closed

Recognize QAT 4xxx devices in System Information Widget

Added by Steve Wheeler 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Hardware / Drivers
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default

Description

The QAT driver supports qat_4xxx devices but they are not shown as supported in the pfSense GUI.

Same as the last update we did: https://redmine.pfsense.org/issues/14844


Files

clipboard-202403041514-6ba0i.png (11.8 KB) clipboard-202403041514-6ba0i.png Brian Dahlquist, 03/04/2024 08:14 PM
Actions #1

Updated by Jim Pingle about 2 months ago

I don't have the hardware to check this but based off the IDs in the source, this diff should do it.

If someone can test and let me know the result, if it works we can commit it. Otherwise we may have to push it back to the next release.

diff --git a/src/usr/local/www/includes/functions.inc.php b/src/usr/local/www/includes/functions.inc.php
index 3b0ad405a1..287e35fbc8 100644
--- a/src/usr/local/www/includes/functions.inc.php
+++ b/src/usr/local/www/includes/functions.inc.php
@@ -245,6 +245,10 @@ define("INTEL_XEOND_QAT", "0x6f548086");
 define("INTEL_XEOND_QAT_VF", "0x6f558086");
 define("INTEL_DH895XCC_QAT", "0x04358086");
 define("INTEL_DH895XCC_QAT_VF", "0x04438086");
+define("INTEL_4XXX_QAT", "0x49408086");
+define("INTEL_4XXX_QAT_VF", "0x49418086");
+define("INTEL_401XX_QAT", "0x49428086");
+define("INTEL_401XX_QAT_VF", "0x49438086");
 define("AESNI_ALGS", "AES-CBC,AES-CCM,AES-GCM,AES-ICM,AES-XTS");
 define("AESNI_ALGS_SHA", "SHA1,SHA256");
 define("QAT_ALGS", "AES-CBC,AES-CCM,AES-GCM,AES-ICM,AES-XTS,SHA1,SHA256,SHA384,SHA512");
@@ -341,7 +345,8 @@ function get_cpu_crypto_support() {
        $QATIDS = [
                INTEL_C2000_IQIA_PHYS, INTEL_200XX_QAT, INTEL_200XX_QAT_VF,
                INTEL_C3K_QAT, INTEL_C3K_QAT_VF, INTEL_C620_QAT, INTEL_C620_QAT_VF,
-               INTEL_XEOND_QAT, INTEL_XEOND_QAT_VF, INTEL_DH895XCC_QAT, INTEL_DH895XCC_QAT_VF
+               INTEL_XEOND_QAT, INTEL_XEOND_QAT_VF, INTEL_DH895XCC_QAT, INTEL_DH895XCC_QAT_VF,
+               INTEL_4XXX_QAT, INTEL_4XXX_QAT_VF, INTEL_401XX_QAT, INTEL_401XX_QAT_VF
        ];

        /* Defaults */
Actions #2

Updated by Brian Dahlquist about 2 months ago

Jim Pingle wrote in #note-1:

I don't have the hardware to check this but based off the IDs in the source, this diff should do it.

If someone can test and let me know the result, if it works we can commit it. Otherwise we may have to push it back to the next release.

[...]

Seems to work for me when I made the edits manually at least:

Actions #3

Updated by Jim Pingle about 2 months ago

  • Assignee set to Jim Pingle

Thanks for testing! I'll commit that diff momentarily.

Actions #4

Updated by Jim Pingle about 2 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Jim Pingle about 1 month ago

  • Subject changed from Add QAT 4xxx to recognised devices list to Recognize QAT 4xxx devices in System Information Widget
Actions #6

Updated by Jim Pingle about 1 month ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF