Feature #15415: Enhance the firewall log action hover information view, show reason info - pfSense - pfSense bugtracker

Actions

Copy link

Feature #15415

open

Enhance the firewall log action hover information view, show reason info

Added by Jim Pingle 8 months ago. Updated 13 days ago.

Status:

New

Priority:

Normal

Assignee:

Category:

Logging

Target version:

2.8.0

Start date:

Due date:

% Done:

Estimated time:

Plus Target Version:

25.03

Release Notes:

Default

Description

Currently hovering over the action icon on a firewall log entry shows a small tooltip with the action text and the rule tracker ID but it isn't clearly presented.

We should turn this into a nicely formatted box that appears when hovering, similar to the one used in other places for aliases, gateway groups, etc.

It should include at least the following:

Action: <action text> ($filterent['act'])
Reason: <reason text> ($filterent['reason'])
Tracker ID: <id> ($filterent['tracker'])

If it's viable, it might be good to show the actual rule there as well so users don't have to click to see it, but that may be slow/inefficient. If the rule can't be added, then the hover text should include a note saying "Click to show matching rule" or similar.

Related issues

Actions

Copy link

Updated by Jim Pingle 8 months ago

Related to Regression #15400: IGMP packets are logged when the filter rule has logging disabled added

Actions

Copy link

Updated by Jim Pingle 8 months ago

For users hitting #15400 who want to see the reason code ("ip-options" in that problem case), this diff will add it to the current tooltip:

diff --git a/src/usr/local/www/status_logs_filter.php b/src/usr/local/www/status_logs_filter.php
index f2e106fad0..4ae88f294b 100644
--- a/src/usr/local/www/status_logs_filter.php
+++ b/src/usr/local/www/status_logs_filter.php
@@ -188,7 +188,7 @@ if (!$rawfilter) {
                        $margin_left = '0.4em';
                }
 ?>
-                                               <i style="margin-left:<?=$margin_left;?>" class="<?=$icon_act;?> icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('status_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i>
+                                               <i style="margin-left:<?=$margin_left;?>" class="<?=$icon_act;?> icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['reason'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('status_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i>
 <?php
                if ($filterent['count']) {
                        echo $filterent['count'];

Actions

Copy link